Skip to content

[4.1] Simplify Requirements for Task Routine XMLs#36515

Merged
bembelimen merged 7 commits intojoomla:4.1-devfrom
ditsuke:fix-image-size-form-sub
Jan 10, 2022
Merged

[4.1] Simplify Requirements for Task Routine XMLs#36515
bembelimen merged 7 commits intojoomla:4.1-devfrom
ditsuke:fix-image-size-form-sub

Conversation

@ditsuke
Copy link
Copy Markdown
Contributor

@ditsuke ditsuke commented Jan 1, 2022 •
edited
Loading

Pull Request for Issue #36449.

Summary of Changes

  • Fixes form for the Image Size Check task routine and improves a language string for clarity.
  • Removes requirement of the "showFront" attribute for the task_params fieldset.

Testing Instructions

  • Admin > System > Scheduled Tasks
  • Click "Create Task" or similar
  • Select "Image Size Check" routine
  • Fill in the form and save

Actual result BEFORE applying this Pull Request

  • Form fails to submit due to validation error (missing required data).
  • Routine XMLs require a showFront="true" attribute.

Expected result AFTER applying this Pull Request

  • Form is submitted, task is created.
  • Routine XMLs no longer require require the attribute to work correctly.

Documentation Changes Required

-

ditsuke added 2 commits January 1, 2022 11:11
@ditsuke
Fix form for image size task routine
5573977 
Fixes duplication of form field for routine configuration and failure to
validate and submit routine form.
@ditsuke
Improve language string for image size routine
65c7dc4 
Adds description to dimension limit (px) for clarity.
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Jan 1, 2022
@Kostelano
Copy link
Copy Markdown
Contributor

Kostelano commented Jan 1, 2022

I have tested this item ✅ successfully on 0d0c644

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

@Kostelano Kostelano mentioned this pull request Jan 1, 2022
Closed
@ditsuke ditsuke mentioned this pull request Jan 1, 2022
Open
@Shubhamverma2796
Copy link
Copy Markdown
Contributor

Shubhamverma2796 commented Jan 2, 2022

I have tested this item ✅ successfully on 8cdd8ec

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

@richard67 richard67 mentioned this pull request Jan 2, 2022
Closed
@jwaisner
Copy link
Copy Markdown
Member

jwaisner commented Jan 3, 2022

I have tested this item ✅ successfully on 8cdd8ec

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

@jwaisner
Copy link
Copy Markdown
Member

jwaisner commented Jan 3, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 3, 2022
@ditsuke ditsuke changed the title [4.1] Fix Form for Image Size Check Task Routine [4.1] Simplify Requirements for Task Routine XMLs Jan 8, 2022
@ditsuke
Copy link
Copy Markdown
Contributor Author

ditsuke commented Jan 8, 2022

Needs tests again I believe

@Kostelano
Copy link
Copy Markdown
Contributor

Kostelano commented Jan 8, 2022

I have tested this item ✅ successfully on 9f11de3

After the changes, everything works.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

@bembelimen
Copy link
Copy Markdown
Contributor

bembelimen commented Jan 10, 2022

I have tested this item ✅ successfully on 9f11de3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

@bembelimen bembelimen merged commit 993a2dc into joomla:4.1-dev Jan 10, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 10, 2022
@bembelimen
Copy link
Copy Markdown
Contributor

bembelimen commented Jan 10, 2022

Thx

@bembelimen bembelimen added this to the Joomla 4.1 milestone Jan 10, 2022
@ditsuke ditsuke deleted the fix-image-size-form-sub branch January 15, 2022 19:30
Kostelano added a commit to JPathRu/localisation that referenced this pull request Jan 22, 2022
@Kostelano
Joomla 4.1 RC1
ac3f2e2 
joomla/joomla-cms#30522 +
joomla/joomla-cms#32223 +
joomla/joomla-cms#31675 +
joomla/joomla-cms#35378 +
joomla/joomla-cms#35612 +
joomla/joomla-cms#35715 +
joomla/joomla-cms#35610 +
joomla/joomla-cms#35607 +
joomla/joomla-cms#35788 +
joomla/joomla-cms#35647 +
joomla/joomla-cms#35143 +
joomla/joomla-cms#36135 +
joomla/joomla-cms#35998 +
joomla/joomla-cms#36173 +
joomla/joomla-cms#36212 +
joomla/joomla-cms#36208 +
joomla/joomla-cms#36206 +
joomla/joomla-cms#36205 +
joomla/joomla-cms#36203 +
joomla/joomla-cms#36192 +
joomla/joomla-cms#36191 +
joomla/joomla-cms#36228 +
joomla/joomla-cms#36211 +
joomla/joomla-cms#36271 +
joomla/joomla-cms#36270 +
joomla/joomla-cms#36245 +
joomla/joomla-cms#36294 +
joomla/joomla-cms#36244 +
joomla/joomla-cms#36242 +
joomla/joomla-cms#36296 +
joomla/joomla-cms#36190 +
joomla/joomla-cms#36474 +
joomla/joomla-cms#36297 +
joomla/joomla-cms#36480 +
joomla/joomla-cms#36479 +
joomla/joomla-cms#36551 +
joomla/joomla-cms#36366 +
joomla/joomla-cms#36589 +
joomla/joomla-cms#36583 +
joomla/joomla-cms#36328 +
joomla/joomla-cms#36515 +
joomla/joomla-cms#36555 +
joomla/joomla-cms#36653 +
joomla/joomla-cms#36660 +
joomla/joomla-cms#36657 +
joomla/joomla-cms#36637 +
joomla/joomla-cms#35983 +
joomla/joomla-cms#36704 +
joomla/joomla-cms#36708 +
joomla/joomla-cms#36700 +
@heelc29 heelc29 mentioned this pull request Mar 26, 2022
Closed
heelc29 added a commit to heelc29/joomla that referenced this pull request Mar 26, 2022
@heelc29
fix joomlagerman#2339
7165f3d 
joomla/joomla-cms#36515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla 4.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ditsuke @Kostelano @Shubhamverma2796 @jwaisner @bembelimen @joomla-cms-bot