[4.1] Images in the Smart Search results by sakiss · Pull Request #35612 · joomla/joomla-cms

sakiss · 2021-09-20T12:20:56Z

Summary of Changes

The PR allows the use of images in the finder's results.

A new setting was added named "Result Image" both in the com_finder's (aka Smart Search) configuration and it's respective "search" menu item.

Testing Instructions

Go to the "Smart Search" component, press the "Clear Index" button and then the "Index".
Press the "Options" button to load the configuration and enable the "Result Image" setting.
Use the smart search in the site's front-end and check the returned articles that have "Intro Image" set.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Sidenotes

Atm only the com_content finder plugin uses the images API function. Support for the rest plugins will be added in a next PR.

There are 3 new settings both in Smart Search Configuration and in Smart Search results menu item:

Result Image > Shows or hides the image in the results.
Image Class > Adds a class to the figure html element. The same that happens with the "Intro Image Class" in com_content.
Linked Image > Creates an anchor for the image. The same that happens with the "Linked Intro Image" in com_content.

Documentation Changes Required

DKN

@ceford @mateoAdi @universewrld it would be great if you could test that again, as i had to close the other PR for that feature.

…e results menu item settings.

Co-authored-by: Brian Teeman <brian@teeman.net>

This reverts commit 89cdda8

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

This reverts commit 8731d82

Co-authored-by: Quy <quy@fluxbb.org>

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

mateoAdi · 2021-09-30T16:20:07Z

I have tested this item ✅ successfully on a22bd51

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35612.}

Fedik

This still need to be fixed #35612 (comment)

sakiss · 2021-10-07T11:15:51Z

@Fedik Done. Plz remove the "Change Requested" label.
Let's hope that this gets 1 more test and finally got merged.

Fedik

Looks much better, thanks

RickR2H · 2021-10-10T17:08:20Z

I have tested this item ✅ successfully on a22bd51

Nice addition to the result page!

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35612.}

RickR2H · 2021-10-10T17:08:59Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35612.}

sakiss · 2021-10-22T09:35:09Z

RTC?

RickR2H · 2021-10-22T09:46:48Z

Hey Sakis, RTC means Ready To Commit. Next it is up to the release lead to decide if it's a good addition to the platform. If so, they will merge the PR. @bembelimen could you take a look at this PR?

sakiss · 2021-10-22T16:50:59Z

@RickR2H the question goes to the release leader

RickR2H · 2021-10-22T20:56:33Z

RL is tagged and PR has been noted!

bembelimen · 2021-10-24T19:36:46Z

Thx

sakiss · 2021-10-25T09:01:55Z

Thanks!

brianteeman · 2022-04-01T14:21:32Z

Can someone please reconfirm that this functionality works as I cant get it show any images at all

sakiss and others added 30 commits September 20, 2021 15:10

Add the image object in the Result item

455e4ea

Add image to content Result

34c3a37

Add a 'show_image' setting, both to the finder's configuration and th…

8a3928f

…e results menu item settings.

Show image defaults to 0 (hide)

656b19d

Add image class setting (as set for the com_content)

4e71f5d

Rename addImage to setImage (we only have 1)

c31f773

getImage function

507bbb3

print the image in the results layout

c4a48c7

code style

ebc7166

Update administrator/components/com_finder/config.xml

e9ffcaa

Co-authored-by: Brian Teeman <brian@teeman.net>

Update administrator/components/com_finder/config.xml

622fb3d

Co-authored-by: Brian Teeman <brian@teeman.net>

Update administrator/components/com_finder/src/Indexer/Result.php

295e207

Co-authored-by: Brian Teeman <brian@teeman.net>

Update components/com_finder/tmpl/search/default.xml

e2954f7

Co-authored-by: Brian Teeman <brian@teeman.net>

Update components/com_finder/tmpl/search/default_result.php

489f29a

Co-authored-by: Brian Teeman <brian@teeman.net>

Fix language constants order

455d132

Revert "Fix language constants order" as it ovewrites github commits

869cb37

This reverts commit 89cdda8

__DEPLOY_VERSION__

e7981c5

alphabetic order to lang constants

abc1837

Update components/com_finder/tmpl/search/default_result.php

dab69de

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

Update components/com_finder/tmpl/search/default_result.php

796b44b

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

CS

b168bfb

Revert "CS"

7c05273

This reverts commit 8731d82

cs hell

448a12c

Tabs

38f868d

alt attribute

b15ae5e

Remove description from class field

2f210ef

initialize $extraAttr

0d5d82b

Update administrator/components/com_finder/config.xml

531a261

Co-authored-by: Quy <quy@fluxbb.org>

docBlocks

7a161c6

Image Url and Image Alt as public scalar properties

a22bd51

sakiss and others added 6 commits September 24, 2021 12:55

Update components/com_finder/tmpl/search/default_result.php

084e874

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

Update administrator/components/com_finder/src/Indexer/Result.php

84c0a1b

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

Update administrator/components/com_finder/src/Indexer/Result.php

a292150

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

1 indent

f5a3a87

!$images then false

c32f0ca

Merge branch '4.1-dev' into finder_images

627dbfd

Fedik requested changes Oct 4, 2021

View reviewed changes

Make Fedir Happy

fc71eb3

Fedik approved these changes Oct 7, 2021

View reviewed changes

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 10, 2021

Merge branch '4.1-dev' into finder_images

75b5d25

bembelimen merged commit 0029528 into joomla:4.1-dev Oct 24, 2021

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 24, 2021

bembelimen added this to the Joomla 4.1 milestone Oct 24, 2021

jgerman-bot mentioned this pull request Oct 24, 2021

[4.1] Images in the Smart Search results joomlagerman/joomla#2111

Closed

sakiss deleted the finder_images branch October 25, 2021 09:02

brianteeman mentioned this pull request Apr 1, 2022

[4.1] search with images broken #37448

Closed

sakiss mentioned this pull request Jul 25, 2023

[5.0] Smart Search to show Contact images #41236

Merged

2 tasks

Uh oh!

Conversation

sakiss commented Sep 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Sidenotes

Documentation Changes Required

Uh oh!

mateoAdi commented Sep 30, 2021

Uh oh!

Fedik left a comment

Choose a reason for hiding this comment

Uh oh!

sakiss commented Oct 7, 2021

Uh oh!

Fedik left a comment

Choose a reason for hiding this comment

Uh oh!

RickR2H commented Oct 10, 2021

Uh oh!

RickR2H commented Oct 10, 2021

Uh oh!

sakiss commented Oct 22, 2021

Uh oh!

RickR2H commented Oct 22, 2021

Uh oh!

sakiss commented Oct 22, 2021

Uh oh!

RickR2H commented Oct 22, 2021

Uh oh!

bembelimen commented Oct 24, 2021

Uh oh!

sakiss commented Oct 25, 2021

Uh oh!

brianteeman commented Apr 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

sakiss commented Sep 20, 2021 •

edited

Loading