Merged
Conversation
Contributor
wilsonge
commented
Aug 31, 2019
- Merge with a merge not a squash/rebase
* Media field style and layout * Small screen considerations * Tweaks * Revert js change * indent * Fix scroll in chrome
Chosen is not accessible so we shouldnt use it unless it offers something useful. In the search component in the front end there are potentially two lists Ordering and display # Neither of these require or benefit from chosen so this simple PR returns them to regular and accessible lists
The $key parameter can be either an array or a string but from PHPDoc it was only an array
* Improvements to mediamanager.js and popup-imagemanager.js - use jquery's prop function instead of attr - properly and consistently encode and decode URI components - explicitly use global variables from the global scope * Wait till the iframe is loaded before doing things that required the iframe to be loaded.
…k on Plus (+) button to add repeated subform joomla#25387 (joomla#25398)
…oomla#25406) Pinned sodium_compat because of file case change, atm this could not be handled by the Joomla! updater.
Joomla! 3.9.10
Contributor
Author
|
Known failure case trying to login into the admin site. So choosing to merge this with the failing test. Tests passed in mysql suggesting that the system tests are largely working and the only postgres changes here relate to template styles EDIT: PostgreSQL passed on the merge commit drone run - so this was indeed just a blip |
brianteeman
reviewed
Aug 31, 2019
| name="fieldfilter" | ||
| type="list" | ||
| label="PLG_FIELDS_TEXT_PARAMS_FILTER_LABEL" | ||
| description="PLG_FIELDS_TEXT_PARAMS_FILTER_DESC" |
Contributor
There was a problem hiding this comment.
this language string is not present in j4 because we removed the usage of the description
Contributor
|
you merged as I was typing an issue. do you want me to submit a pr or will you add to the commit |
Contributor
Author
|
Sorry - can you do a PR please. Just saw this and about to head to bed. |
Contributor
|
done #26112 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.