Correct active file highlight in Template Manager#25399
Merged
HLeithner merged 2 commits intojoomla:stagingfrom Jul 2, 2019
SharkyKZ:j3/templateActiveFile
Merged
Correct active file highlight in Template Manager#25399HLeithner merged 2 commits intojoomla:stagingfrom SharkyKZ:j3/templateActiveFile
HLeithner merged 2 commits intojoomla:stagingfrom
SharkyKZ:j3/templateActiveFile
Conversation
Contributor
|
I have tested this item ✅ successfully on e59a420 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25399. |
1 similar comment
Member
|
I have tested this item ✅ successfully on e59a420 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25399. |
|
Status "Ready To Commit". |
Member
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #25395.
Summary of Changes
Corrects active file detection in file editor.
Testing Instructions
Create two files in template directory. One file name should contain the file name of another file. E.g.
menu.phpandnewmenu.php.Edit
menu.phpin Template Manager.Check highlighted files on the left.
Expected result
menu.phphighlighted.Actual result
menu.phpandnewmenu.phpare highlighted.Documentation Changes Required
No.