@n3t it looks like you committed to the wrong branch?

:-/ yeah, I am not so much familier with github, bit lost now...

Ok, now it should be as before, sorry for complications...

@n3t close this Issue?

@franz-wohlkoenig no this should be still a valid fix for the issue.

@franz-wohlkoenig even commits are bit masched up, it still solves the initial issue, and the PR is back in its initial state.

I have tested this item ✅ successfully on 277b7ae

open basedir message disappears after applying patch

I couldn't reproduce the issue on Linux-4.17.8-1 with PHP7

@icampus

I have tested this item 🔴 unsuccessfully on e1d08ad

I followed the instructions step by step but i coundn't reproduce the issue. I think it can be close.

@icampus

@n3t Can you please followup on the unsuccessful tests? Thank you.

IMO negative tests were not carried out with full understanding of the problem.

Example.
Php has access to /var/images, then we want to list directory like

$folder = new DirectoryIterator(JPATH_ROOT . '/images');  // In real, it will be `/var/images`

and now we have a list of elements:

.
..
image1.png
image2.png

when we are in line .., php want to get access to /var/images/.. which is /var and then we get the error because php has access only to /var/images not /var.

This PR is valid. I did code review.

@csthomas Thank you for your input. @Schmidie64 @niklas-deworetzki-thm Please review your testing and check again.

@csthomas oh, now I see the problem here. I'm sorry, I misunderstood at first, that he had problems with accessing the symlinked directory.
But as far as I understand now, the problem is not the symlink. PHP tries to check isDir on .. . This folder is not in baseDir. So PHP fails and shows an error. And this error is 1. unnecessary and 2. shows critical information about the system path to the user.

I'm testing it now, knowing the real issue. Thank you for clarifying it.

@icampus

I have tested this item ✅ successfully on e1d08ad

Tested this ✅ successfully as specified by @csthomas

@henkrijneveld can you please retest?

@csthomas yes your explanation is exact. problem is not symlink itself, but isdir check to dots folders, which don't need to be accessible...

@Schmidie64 Can you please test this again?

Thx @n3t, good things need sometime sometimes...