Fix update extracted files counter#25198
Merged
HLeithner merged 5 commits intojoomla:stagingfrom Jul 2, 2019
Quy:patch-3
Merged
Fix update extracted files counter#25198HLeithner merged 5 commits intojoomla:stagingfrom Quy:patch-3
HLeithner merged 5 commits intojoomla:stagingfrom
Quy:patch-3
Conversation
Contributor
|
Tested update from 3.9.4 |
|
@frostmakk please mark your test as unsuccessfully (how to: https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results) |
Contributor
|
Not sure it would be correct to mark as unsuccessful, as long as the PR probably didn't address my view of the issue anyway. |
|
@frostmakk if you have a different issue which isn't solved by this Pull Request and not reported yet please open a new Issue. |
Contributor
Author
|
@frostmakk I will look into it and fix it here. |
added 2 commits
June 18, 2019 16:12
Contributor
|
I have tested this item ✅ successfully on 7abf0a8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25198. |
Contributor
|
I have tested this item ✅ successfully on 5e50e37 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25198. |
Contributor
|
since 1st test only branch merge so 2 tests This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25198. |
Member
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #21922 .
Summary of Changes
During update, 4 counters are visible (percent complete, bytes read, bytes extracted and files extracted). Expected is that the values of all counters increase during the update.
This PR uses the cumulative total and not the extracted files count.
Testing Instructions
Install the previous version of Joomla.
Install patch.
Then update to the current version.
or code review
Actual result
The value of files extracted increases and decreases.