Skip to content

Fix for menu items containing nested field groups and no immediate fields in request#25213

Merged
HLeithner merged 3 commits intojoomla:stagingfrom
SharkyKZ:j3/menuItemRequest
Jun 25, 2019
Merged

Fix for menu items containing nested field groups and no immediate fields in request#25213
HLeithner merged 3 commits intojoomla:stagingfrom
SharkyKZ:j3/menuItemRequest

Conversation

@SharkyKZ
Copy link
Copy Markdown
Contributor

@SharkyKZ SharkyKZ commented Jun 15, 2019 •
edited
Loading

Pull Request for Issue #25211.

Summary of Changes

Get request group fields recursively.

Testing Instructions

Create/modify view layout XML file to contain a nested field group but no immediate fields in request field group, e.g.:

<fields name="request">
	<fieldset name="request">
		<fields name="filter">
			<field
				name="id"
				type="category"
				label="JGLOBAL_FIELD_CATEGORIES_CHOOSE_CATEGORY_LABEL"
				description="JGLOBAL_FIELD_CATEGORIES_CHOOSE_CATEGORY_DESC"
				extension="com_content"
				show_root="true"
				required="true"
			/>
		</fields>
	</fieldset>
</fields>

Create a menu item for the view.
Inspect Link field value.

Expected result

Nested group field parameters included, e.g.:

index.php?option=com_content&view=categories&filter[id]=0

Actual result

Nested group field parameters not included, e.g.:

index.php?option=com_content&view=categories

Documentation Changes Required

No.

@muesliflyer
Copy link
Copy Markdown

muesliflyer commented Jun 15, 2019

This works for me. Thanks for the quick fix.

@ghost
Copy link
Copy Markdown

ghost commented Jun 16, 2019

@muesliflyer please mark your test as successfully (how to: https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results)

@muesliflyer
Copy link
Copy Markdown

muesliflyer commented Jun 16, 2019

I have tested this item ✅ successfully on 914b2c8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25213.

@muesliflyer
Copy link
Copy Markdown

muesliflyer commented Jun 16, 2019

For the test, I installed Patch Tester 2.0.1 (the stable version). When fetching the patch data, I got an error:

Notice: Undefined offset: 0 in /var/www/bugtesting/libraries/joomla/database/query.php on line 351 {"success":false,"message":"Error inserting pull request data into the database: Column count doesn't match value count at row 1","messages":null,"data":null}

Then I installed the latest version 3.0.0 beta 4. Then it worked.

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jun 17, 2019

Then I installed the latest version 3.0.0 beta 4. Then it worked.

??

@SharkyKZ
Copy link
Copy Markdown
Contributor Author

SharkyKZ commented Jun 17, 2019

@infograf768 it's about Patchtester.

@viocassel
Copy link
Copy Markdown
Contributor

viocassel commented Jun 25, 2019

I have tested this item ✅ successfully on 5bba89d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25213.

@ghost
Copy link
Copy Markdown

ghost commented Jun 25, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 25, 2019
@HLeithner HLeithner merged commit c684a8f into joomla:staging Jun 25, 2019
@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented Jun 25, 2019

thx

@HLeithner HLeithner added this to the Joomla 3.9.9 milestone Jun 25, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.9.9

Development

Successfully merging this pull request may close these issues.

6 participants

@SharkyKZ @muesliflyer @infograf768 @viocassel @HLeithner @joomla-cms-bot