Fix Frontend Site Configuration error on save#25404
Merged
HLeithner merged 2 commits intojoomla:stagingfrom Jul 2, 2019
Merged
Fix Frontend Site Configuration error on save#25404HLeithner merged 2 commits intojoomla:stagingfrom
HLeithner merged 2 commits intojoomla:stagingfrom
Conversation
conseilgouz
reviewed
Jul 2, 2019
Contributor
conseilgouz
left a comment
There was a problem hiding this comment.
Working fine for me.
Thank you
Contributor
|
Seems to work. Just got to wonder what caused this to break or how long it was broken. |
Contributor
|
I have tested this item ✅ successfully on ee9f9eb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25404. |
Contributor
|
@pmleconte please submit your test result https://docs.joomla.org/Testing_Joomla!_patches. |
Member
Author
|
@pmleconte Could you mark your test result as successful on https://issues.joomla.org/tracker/joomla-cms/25404 by using the "Test this" button? |
Member
Author
Contributor
|
I have tested this item ✅ successfully on ee9f9eb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25404. |
|
Status "Ready To Commit". |
Member
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #25385 .
Summary of Changes
Add admin paths to the search paths for form and its fields for loading the configuration form for frontend editing of site configuration options.
Testing Instructions
Create a menu type "Configuration manager", "Site Configuration options", access "Super User". Go to FrontEnd and log as superuser. Site Configutration is displayed and may be updated. Click on Save button.
Expected result
Configuration saved.
Actual result
Error 0 - Call to a member function filter() on boolean.
Documentation Changes Required
None.