Fix database error after new installation of current staging#25299
Merged
HLeithner merged 5 commits intojoomla:stagingfrom Jun 25, 2019
Merged
Fix database error after new installation of current staging#25299HLeithner merged 5 commits intojoomla:stagingfrom
HLeithner merged 5 commits intojoomla:stagingfrom
Conversation
Member
Author
|
Appveyor failure seems not to be related to this PR. |
Member
Author
|
@alikon Please test as soon as you find time. Check also the links in #25293 (comment) for my changes on the indexes. |
Member
Author
|
@HLeithner I think this is a release blocker. |
Member
Author
|
@franz-wohlkoenig Thanks. |
Contributor
|
I have tested this item ✅ successfully on c21850b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25299. |
Contributor
|
I have tested this item ✅ successfully on c21850b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25299. |
Member
Author
|
@Quy Thanks for testing. Could you add the RTC label? Nicola doesn't have that privilege anymore. |
|
Status "Ready To Commit". |
Member
Author
|
Thanks |
Member
|
thx |
Member
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #25293 .
Summary of Changes
This PR fixes 2 problems coming from PR #24595 :
ALTER TABLE "#__template_style"instead ofALTER TABLE "#__template_styles"in the schema update from PR [SQL] fix field home of #__template_styles table #24595 for postgresql.Testing Instructions
idx_homeshould not exist, 2.idx_client_idshould exist, and 3.idx_client_id_homeshould exist.For Postgresql the number of errors shown in step 4 and for the actual result is different because of the typo in the schema update for postgresql without this PR, but at the end the result will be the same: Fix button in step 5 fixes it, and after new install with this PR applied there are no errors.
Expected result
No database errors.
Actual result
1 error:
Table 'xyz_template_styles' should not have index 'idx_home'. (From file 3.9.8-2019-06-15.sql.)Documentation Changes Required
None.