[com_fields] Fix/Improve checks for empty output in field groups#25145
Merged
HLeithner merged 11 commits intojoomla:stagingfrom Jun 25, 2019
Merged
[com_fields] Fix/Improve checks for empty output in field groups#25145HLeithner merged 11 commits intojoomla:stagingfrom
HLeithner merged 11 commits intojoomla:stagingfrom
Conversation
laoneo
approved these changes
Jun 9, 2019
Quy
reviewed
Jun 9, 2019
Quy
reviewed
Jun 9, 2019
Co-Authored-By: Quy <quy@fluxbb.org>
Contributor
Author
|
Updated with @Quy suggestions, thanks! |
Quy
reviewed
Jun 9, 2019
Contributor
|
I have tested this item ✅ successfully on ff61169 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145. |
1 similar comment
Member
|
I have tested this item ✅ successfully on ff61169 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145. |
SharkyKZ
reviewed
Jun 10, 2019
SharkyKZ
reviewed
Jun 10, 2019
Contributor
|
I have tested this item ✅ successfully on d6c16be This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145. |
Contributor
Author
|
To merge in 3.9.8? Edit: 3.9.9 now I guess :D |
Contributor
|
@AndySDH Please apply the suggested changes. It will not require retesting. |
Co-Authored-By: SharkyKZ <sharkykz@gmail.com>
Co-Authored-By: SharkyKZ <sharkykz@gmail.com>
Contributor
Author
|
I wasn't too sure the suggested changes made much sense as there's no need to compare for data type when we are comparing to an empty string. But ok, I applied them. |
Contributor
Author
|
Reminder about this for 3.9.9 |
calling Release Lead @HLeithner to be sure. |
Member
|
thx |
|
@AndySDH can you please mail me wohlkoenig.franz@gmail.com |
Contributor
Author
I did |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR improves checks for empty output when rendering a field as part of field groups. Some checks were already there but not thorough, and empty output could occur in rare cases.
This makes sure that a field that has an empty value or an empty output does not get displayed in all cases.
One check comes from the original subfields PR (https://github.com/joomla/joomla-cms/pull/22446/files#diff-02a314737553eb71a8516e925b220cce) that was postponed to Joomla 4.
Another extra check I added myself.
Testing Instructions
Not much needed really. Just double checks.
Expected result
Field with empty output should never display
Actual result
Field with empty output could be displayed in rare occurrences
Documentation Changes Required
None