Skip to content

Fix the path for the ajax-loader.gif#16701

Merged
mbabker merged 2 commits intojoomla:stagingfrom
Fedik:fix-spinning-logo
Jul 25, 2017
Merged

Fix the path for the ajax-loader.gif#16701
mbabker merged 2 commits intojoomla:stagingfrom
Fedik:fix-spinning-logo

Conversation

@Fedik
Copy link
Copy Markdown
Member

@Fedik Fedik commented Jun 15, 2017

Pull Request for Issue #15305 and altornative to #15529 .

Summary of Changes

Fix the path for the ajax-loader.gif

Testing Instructions

Please see #15305 and #15529

Documentation Changes Required

none

var basePath = document.getElementsByTagName('body')[0].getAttribute('data-basepath') || '';
// Gets the site base path
var systemPaths = Joomla.getOptions('system.paths') || {},
basePath = systemPaths.root || '';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra spaces.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the editor it looks perfect :neckbeard:
screen 2017-06-15 20 35 24 725x120

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks off in the GitHub UI and in my editor with downloaded raw version.

spaces

@ghost
Copy link
Copy Markdown

ghost commented Jun 15, 2017

Tested with and -out Menu "Create Article" and with and -out PR got no Error in Console>JS.

System information

3.7.3-dev (latest nightly build)
Multilanguage Site
macOS Sierra, 10.12.5
Firefox 54 (64-bit)

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jun 15, 2017

@franz-wohlkoenig Without the pr, I get the error when editing an article in the frontend.

@infograf768
Copy link
Copy Markdown
Member

Firefox
I do not get the error either.
Is the ajax-loader.gif supposed to be displayed when saving such an article?
The only error I get is:
Empty string passed to getElementById().jquery.min.js:2:24932

@infograf768
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 502183a

Safari displays the error. Patch solves the issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16701.

@ghost
Copy link
Copy Markdown

ghost commented Jun 16, 2017

I have tested this item ✅ successfully on 502183a

Didn't get Error in Safari on Mac, but on Chrome.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16701.

@ghost
Copy link
Copy Markdown

ghost commented Jun 16, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 16, 2017
@rdeutz rdeutz modified the milestone: Joomla 3.7.4 Jun 21, 2017
@rdeutz rdeutz modified the milestones: Joomla 3.8.0, Joomla 3.7.4 Jul 11, 2017
@mbabker
Copy link
Copy Markdown
Contributor

mbabker commented Jul 19, 2017

Merge conflicts need to be resolved.

 Conflicts:
	media/system/js/core.js
@zero-24 zero-24 changed the base branch from staging to 3.8-dev July 19, 2017 15:49
@zero-24 zero-24 changed the base branch from 3.8-dev to staging July 19, 2017 15:50
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 25, 2017
roland-d added a commit to roland-d/joomla-cms that referenced this pull request Jul 26, 2017
* staging: (274 commits)
  Add JCryptCipherSodium to support libsodium (joomla#16754)
  Performance 2 (libraries/legacy) (joomla#12220)
  Performance 6 (templates) (joomla#12233)
  Fixed typehint (joomla#16425)
  Fix for: Repeatable field is no longer rendered with Chosen layout (joomla#16471)
  Fix the path for the ajax-loader.gif (joomla#16701)
  Menu items list parent filter (joomla#17060)
  Text Filters layout (joomla#17113)
  mod_login showon option (joomla#17153)
  com_banners incorret tooltip (joomla#17157)
  fix joomla.content.options_default (joomla#17123)
  remove the never working limitstart call (joomla#17184)
  Update phpDocumentor build
  set 3.8.0 Dev State
  Prepare 3.7.4 Stable Release
  fixed a logic change in joomla#12294, thanks @Hoffi1
  Update sv-SE.ini
  Update pt-BR.ini
  Update lv-LV.ini
  Update fa-IR.ini
  ...
@Fedik Fedik deleted the fix-spinning-logo branch July 26, 2017 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants