Fixed the typehint for quote functions in JDatabaseDriver#16425
Merged
mbabker merged 1 commit intojoomla:stagingfrom Jul 25, 2017
Merged
Fixed the typehint for quote functions in JDatabaseDriver#16425mbabker merged 1 commit intojoomla:stagingfrom
JDatabaseDriver#16425mbabker merged 1 commit intojoomla:stagingfrom
Conversation
Fixed the typehint for quote functions in `JDatabaseDriver`
mbabker
approved these changes
Jun 1, 2017
Contributor
|
I have tested this item ✅ successfully on 88ce41a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16425. |
Contributor
|
I have tested this item ✅ successfully on 88ce41a We have lot of such issues all over the cms that needs to be addressed. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16425. |
|
RTC after two successful tests. |
roland-d
added a commit
to roland-d/joomla-cms
that referenced
this pull request
Jul 26, 2017
* staging: (274 commits) Add JCryptCipherSodium to support libsodium (joomla#16754) Performance 2 (libraries/legacy) (joomla#12220) Performance 6 (templates) (joomla#12233) Fixed typehint (joomla#16425) Fix for: Repeatable field is no longer rendered with Chosen layout (joomla#16471) Fix the path for the ajax-loader.gif (joomla#16701) Menu items list parent filter (joomla#17060) Text Filters layout (joomla#17113) mod_login showon option (joomla#17153) com_banners incorret tooltip (joomla#17157) fix joomla.content.options_default (joomla#17123) remove the never working limitstart call (joomla#17184) Update phpDocumentor build set 3.8.0 Dev State Prepare 3.7.4 Stable Release fixed a logic change in joomla#12294, thanks @Hoffi1 Update sv-SE.ini Update pt-BR.ini Update lv-LV.ini Update fa-IR.ini ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Changed the typehint of quote function from string to string and array to reflect actual function return type
Testing Instructions
Code review
Documentation Changes Required
Update typehint