Remove the never working limitstart call#17184
Closed
zero-24 wants to merge 2 commits intojoomla:stagingfrom
Closed
Remove the never working limitstart call#17184zero-24 wants to merge 2 commits intojoomla:stagingfrom
zero-24 wants to merge 2 commits intojoomla:stagingfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on d39631b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17184. |
|
I have tested this item ✅ successfully on d39631b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17184. |
|
RTC after two successful tests. |
Contributor
Author
|
@mbabker I'm not sure what happend here if you have a few minutes please check this. |
Contributor
|
You started the PR based on staging then changed the branch to 3.8. But your staging branch is a few commits ahead of the 3.8 branch (expected, the commits in this PR aren't merged to 3.8 yet). So it's fine for now, I just have to remember to merge staging to 3.8 before merging this PR. |
Contributor
Author
|
Thans for checking! |
Contributor
roland-d
added a commit
to roland-d/joomla-cms
that referenced
this pull request
Jul 26, 2017
* staging: (274 commits) Add JCryptCipherSodium to support libsodium (joomla#16754) Performance 2 (libraries/legacy) (joomla#12220) Performance 6 (templates) (joomla#12233) Fixed typehint (joomla#16425) Fix for: Repeatable field is no longer rendered with Chosen layout (joomla#16471) Fix the path for the ajax-loader.gif (joomla#16701) Menu items list parent filter (joomla#17060) Text Filters layout (joomla#17113) mod_login showon option (joomla#17153) com_banners incorret tooltip (joomla#17157) fix joomla.content.options_default (joomla#17123) remove the never working limitstart call (joomla#17184) Update phpDocumentor build set 3.8.0 Dev State Prepare 3.7.4 Stable Release fixed a logic change in joomla#12294, thanks @Hoffi1 Update sv-SE.ini Update pt-BR.ini Update lv-LV.ini Update fa-IR.ini ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Remove the never working limitstart call. I did go back in the history and that not working call is included since the intial commit to GitHub:
https://github.com/joomla/joomla-cms/blame/56fbf2c55293b3188c7d85163dfcf91eac01741c/components/com_content/helpers/icon.php#L106-L110
Intial report by @moira-lachesis
Testing Instructions
Confirm that the print button in the frontend still works.
Expected result
The print button in the frontend still works.
Actual result
The print button in the frontend works but append a empty an unused
&page=.Documentation Changes Required
None.