Menu items list parent filter by tonypartridge · Pull Request #17060 · joomla/joomla-cms

tonypartridge · 2017-07-10T22:25:59Z

Pull Request for Issue #16882 .

Summary of Changes

Removes duplicate state filter
Added parent_id filtering

Testing Instructions

Install patch, view list of menu items. Select search tools to show more search options and a new filter is on the right. called '- Select Parent Menu Item -'.

… menu item

Quy · 2017-07-10T22:53:12Z

administrator/components/com_menus/models/forms/filter_items.xml

 			<option value="">JOPTION_SELECT_MAX_LEVELS</option>
 		</field>
+		<field
+				name="parent_id"


Fix tab/spacing.

It's late.. and drone didn't fail! :/ now fixed. Thanks!

Drone is JS tests...don't be blaming drone :P

brianteeman · 2017-07-10T22:55:05Z

administrator/language/en-GB/en-GB.com_menus.ini

 COM_MENUS_XML_DESCRIPTION="Component for creating menus."
 JLIB_RULES_SETTING_NOTES="Changes apply to this component only.<br /><em><strong>Inherited</strong></em> - a Global Configuration setting or higher level setting is applied.<br /><em><strong>Denied</strong></em> always wins - whatever is set at the Global or higher level and applies to all child elements.<br /><em><strong>Allowed</strong></em> will enable the action for this component unless it is overruled by a Global Configuration setting."
+COM_MENUS_FILTER_SELECT_PARENT_MENU_ITEM="- Select Parent Menu Item -"
+COM_MENUS_FILTER_PARENT_MENU_ITEM="Parent Menu Item"


COM_MENUS_FILTER_PARENT_MENU_ITEM_LABEL please

coolcat-creations · 2017-07-11T08:47:20Z

Cool thank you :) Will test it asap

GeraintEdwards · 2017-07-11T10:02:03Z

Test failed :(

Select 'Site Map' as parent_id and the list does indeed filter to show the correct subitems but the 'search tools disappear' - you need to add parent_id and a.parent_id to $config['filter_fields'] in the model constructor otherwise the 'search tools' disappear when you select a parent filter (with no other filters enabled).

Additionally it would be good for the parent item list to be filtered based on the main 'menu filter'.

ghost · 2017-07-11T10:10:21Z

@GeraintEdwards i altered your unsuccessfully Test at issue Tracker.

…use.

tonypartridge · 2017-07-11T10:13:33Z

Thanks @GeraintEdwards now resolved.

GeraintEdwards · 2017-07-11T10:29:37Z

I have tested this item ✅ successfully on ad24cdb

Menu items are filtered correctly and the filter remains visible in the 'search tools'

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17060.}

…Menu Type if is filtered by Menu Type.

tonypartridge · 2017-07-11T11:06:33Z

Now updated @coolcat-creations @GeraintEdwards to include a custom field type which dynamically filters the menu items by menu type if the menu items in the list are already filter by type.

tonypartridge · 2017-07-11T11:40:30Z

@rdeutz jenkis php70 docker isn't connecting?

coolcat-creations · 2017-07-11T12:11:22Z

I have tested this item ✅ successfully on 0b3ed6f

Thank you, it works! Great improvement for large sites :)

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17060.}

ghost · 2017-07-11T12:13:28Z

@GeraintEdwards can you please retest?

GeraintEdwards · 2017-07-11T13:31:22Z

I have tested this item ✅ successfully on 0b3ed6f

Filtering by menu type is a big functional improvement - thanks for adding it in.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17060.}

ghost · 2017-07-11T13:35:58Z

RTC after two successful tests.

rdeutz · 2017-07-12T09:45:07Z

@tonypartridge you don't need to care about the new jenkins setup, we are still in testing mode

tonypartridge · 2017-07-12T09:46:02Z

That's fine, just didn't think it gets accepted unless all tests are passed. Thanks!

…

On 12 Jul 2017, 10:45 +0100, Robert Deutz ***@***.***>, wrote: @tonypartridge you don't need to care about the new jenkins setup, we are still in testing mode — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

rdeutz · 2017-07-12T09:50:20Z

travis and drone are required

Quy · 2017-07-12T12:15:29Z

administrator/components/com_menus/models/fields/menuitembytype.php

+			// Build the options array.
+			foreach ($items as $key => $link)
+			{
+


Remove empty line.

This is standard from the original menuitem.php file

Quy · 2017-07-12T12:16:03Z

administrator/language/en-GB/en-GB.com_menus.ini

 COM_MENUS_VIEW_NEW_MENU_TITLE="Menus: Add"
 COM_MENUS_XML_DESCRIPTION="Component for creating menus."
 JLIB_RULES_SETTING_NOTES="Changes apply to this component only.<br /><em><strong>Inherited</strong></em> - a Global Configuration setting or higher level setting is applied.<br /><em><strong>Denied</strong></em> always wins - whatever is set at the Global or higher level and applies to all child elements.<br /><em><strong>Allowed</strong></em> will enable the action for this component unless it is overruled by a Global Configuration setting."
+COM_MENUS_FILTER_SELECT_PARENT_MENU_ITEM="- Select Parent Menu Item -"


Alpha order strings.

tonypartridge · 2017-07-12T13:00:37Z

Made some slight changes as per @Quy 's request. Should not need retesting, nothing has changed apart from code style.

Quy · 2017-07-12T13:08:26Z

Actually, the lines should be moved after line 39.

Quy · 2017-07-12T17:00:40Z

administrator/components/com_menus/models/forms/filter_items.xml

+			name="parent_id"
+			type="menuitembytype"
+			label="COM_MENUS_FILTER_PARENT_MENU_ITEM_LABEL"
+			description="COM_MENUS__FILTER_PARENT_MENU_DESC"


Fix typo. Use COM_MENUS_FILTER_PARENT_MENU_ITEM_DESC

Quy · 2017-07-12T17:02:36Z

administrator/language/en-GB/en-GB.com_menus.ini

 COM_MENUS_FIELD_VALUE_NEW_WITHOUT_NAV="New Without Navigation"
 COM_MENUS_FIELD_VALUE_PARENT="Parent"
 COM_MENUS_FIELDSET_RULES="Permissions"
+COM_MENUS_FILTER_SELECT_PARENT_MENU_ITEM="- Select Parent Menu Item -"


These have to be in alpha order.

COM_MENUS_FILTER_PARENT_MENU_ITEM_DESC COM_MENUS_FILTER_PARENT_MENU_ITEM_LABEL COM_MENUS_FILTER_SELECT_PARENT_MENU_ITEM

tonypartridge · 2017-07-17T09:09:47Z

@rdeutz has someone changed AppVeyor? This passed last week without issue, all I have done is moved language strings around in the .xml for @Quy ?

rdeutz · 2017-07-17T09:20:16Z

@tonypartridge it's nothing you can really count on, if they have failed I look into it and most of the time it is simply a wrong test result

mbabker · 2017-07-19T12:12:49Z

administrator/components/com_menus/models/fields/menuitembytype.php

+JFormHelper::loadFieldClass('groupedlist');
+
+// Import the com_menus helper.
+require_once realpath(JPATH_ADMINISTRATOR . '/components/com_menus/helpers/menus.php');


Use JLoader::register() here.

mbabker · 2017-07-19T12:13:32Z

administrator/components/com_menus/models/fields/menuitembytype.php

+	 */
+	public function setup(SimpleXMLElement $element, $value, $group = null)
+	{
+		$app = JFactory::getApplication('administrator');


You can move this line down to inside the if (!$menuType) as you aren't always using the app.

mbabker · 2017-07-19T12:14:43Z

administrator/components/com_menus/models/fields/menuitembytype.php

+					}
+
+					$groups[$menu->title][] = JHtml::_('select.option',
+						$link->value, $levelPrefix . $link->text . $lang,


If you're going to split the parameters across multiple lines, there should be one parameter per line (this line has two)

tonypartridge · 2017-07-19T12:16:04Z

I’ve just copied the core Joomla! Menuitem.php type……..

…

On 19 Jul 2017, 13:14 +0100, Michael Babker ***@***.***>, wrote: @mbabker commented on this pull request. In administrator/components/com_menus/models/fields/menuitembytype.php: > + foreach ($menu->links as $link) + { + $levelPrefix = str_repeat('- ', $link->level - 1); + + // Displays language code if not set to All + if ($link->language !== '*') + { + $lang = ' (' . $link->language . ')'; + } + else + { + $lang = ''; + } + + $groups[$menu->title][] = JHtml::_('select.option', + $link->value, $levelPrefix . $link->text . $lang, If you're going to split the parameters across multiple lines, there should be one parameter per line (this line has two) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

…ms-parent-filter

tonypartridge · 2017-07-25T23:38:29Z

Thanks @mbabker 👍

…

On 26 Jul 2017, 00:37 +0100, Michael Babker ***@***.***>, wrote: Merged #17060. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

@Hoffi1

* staging: (274 commits) Add JCryptCipherSodium to support libsodium (joomla#16754) Performance 2 (libraries/legacy) (joomla#12220) Performance 6 (templates) (joomla#12233) Fixed typehint (joomla#16425) Fix for: Repeatable field is no longer rendered with Chosen layout (joomla#16471) Fix the path for the ajax-loader.gif (joomla#16701) Menu items list parent filter (joomla#17060) Text Filters layout (joomla#17113) mod_login showon option (joomla#17153) com_banners incorret tooltip (joomla#17157) fix joomla.content.options_default (joomla#17123) remove the never working limitstart call (joomla#17184) Update phpDocumentor build set 3.8.0 Dev State Prepare 3.7.4 Stable Release fixed a logic change in joomla#12294, thanks @Hoffi1 Update sv-SE.ini Update pt-BR.ini Update lv-LV.ini Update fa-IR.ini ...

Tony Partridge - xtech86 added 2 commits July 10, 2017 22:51

removed duplicate parentId state

6672151

New feature - Filter menu items by parent item. For issues joomla#16882

598a079

joomla-cms-bot added Language Change This is for Translators PR-staging labels Jul 10, 2017

pre-select menu item parent if filtered by parent when creating a new…

04c294f

… menu item

Quy reviewed Jul 10, 2017

View reviewed changes

fixed slack tabbing

89721f5

brianteeman reviewed Jul 10, 2017

View reviewed changes

Language changes as per @brianteeman

143af31

tonypartridge changed the title ~~Staging menu items parent filter~~ Menu items list parent filter Jul 10, 2017

ghost mentioned this pull request Jul 11, 2017

[UX] Feature Request: Selecting Parent Menu Item #16882

Closed

Added parent_id to constructor so the search tools stay open when in …

ad24cdb

…use.

Added new field filter for menu items which is filter dynamically by …

0fb89bf

…Menu Type if is filtered by Menu Type.

tonypartridge added 4 commits July 11, 2017 12:08

Code style changes

d54c375

Code style changes

4f3bbe0

Code style changes - Codesniffer auto

1eb271a

Reverted CodeSniffer auto fix and applied single fix.

0b3ed6f

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 11, 2017

rdeutz added this to the Joomla 3.8.0 milestone Jul 11, 2017

Quy reviewed Jul 12, 2017

View reviewed changes

Made changes requested by @Quy

2127164

Moved to alpha ordering.

6d62ab0

Quy reviewed Jul 12, 2017

View reviewed changes

Updated as oer @Quy 's comments

ceb1423

mbabker reviewed Jul 19, 2017

View reviewed changes

tonypartridge and others added 3 commits July 21, 2017 10:31

Merge remote-tracking branch 'upstream/staging' into staging-menu-ite…

cd81874

…ms-parent-filter

Updated changes as per @mbabker 's comments.

e3fd019

Version placeholder, not new in 1.6 ;-)

8a43b94

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 25, 2017

Uh oh!

Conversation

tonypartridge commented Jul 10, 2017 • edited by joomla-cms-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coolcat-creations commented Jul 11, 2017

Uh oh!

GeraintEdwards commented Jul 11, 2017

Uh oh!

ghost commented Jul 11, 2017

Uh oh!

tonypartridge commented Jul 11, 2017

Uh oh!

GeraintEdwards commented Jul 11, 2017

Uh oh!

tonypartridge commented Jul 11, 2017

Uh oh!

tonypartridge commented Jul 11, 2017

Uh oh!

coolcat-creations commented Jul 11, 2017

Uh oh!

ghost commented Jul 11, 2017

Uh oh!

GeraintEdwards commented Jul 11, 2017

Uh oh!

ghost commented Jul 11, 2017

Uh oh!

rdeutz commented Jul 12, 2017

Uh oh!

tonypartridge commented Jul 12, 2017 via email

Uh oh!

rdeutz commented Jul 12, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tonypartridge commented Jul 12, 2017

Uh oh!

Quy commented Jul 12, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tonypartridge commented Jul 17, 2017

Uh oh!

rdeutz commented Jul 17, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tonypartridge commented Jul 19, 2017 via email

Uh oh!

tonypartridge commented Jul 25, 2017 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

tonypartridge commented Jul 10, 2017 •

edited by joomla-cms-bot

Loading