Skip to content

Fix for: Repeatable field is no longer rendered with Chosen layout#16471

Merged
mbabker merged 1 commit intojoomla:stagingfrom
Fedik:fix-chosen-repetable
Jul 25, 2017
Merged

Fix for: Repeatable field is no longer rendered with Chosen layout#16471
mbabker merged 1 commit intojoomla:stagingfrom
Fedik:fix-chosen-repetable

Conversation

@Fedik
Copy link
Copy Markdown
Member

@Fedik Fedik commented Jun 3, 2017 •
edited by joomla-cms-bot
Loading

Pull Request for Issue #16110

Summary of Changes

The patch rerender Chosen.js if it was there before

Testing Instructions

please see #16110 and #14556 for detail

Example xml which can be used for test:

<field name="repeatable" type="repeatable" icon="list" label="Repeatable" select="select">
	<fieldset hidden="true" name="repeatable_modal" repeat="true">

			<field type="list" name="list1" label="List1">
			<option>- Select -</option>
			<option value="val1">val 1</option>
			<option value="val2">val 2</option>
			<option value="val3">val 3</option>
		</field>

		<field type="list" name="list2" label="List2" multiple="true">
			<option>- Select -</option>
			<option value="val4">val 4</option>
			<option value="val5">val 5</option>
			<option value="val6">val 6</option>
			<option value="val7">val 7</option>
			<option value="val8">val 8</option>
		</field>
	</fieldset>
</field>

Expected result

Chosen.js rendered

Actual result

Only default <selec> list

Documentation Changes Required

none

@Fedik Fedik mentioned this pull request Jun 3, 2017
Closed
@Fedik
Copy link
Copy Markdown
Member Author

Fedik commented Jun 3, 2017

@N6REJ please test also

laoneo
laoneo reviewed Jun 3, 2017
View reviewed changes
media/system/js/repeatable-uncompressed.js
var $el = $(this);
if ($el.data('chosen')) {
$el.chosen('destroy');
$el.addClass('here-was-chosen');
Copy link
Copy Markdown
Member

@laoneo laoneo Jun 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice class name 😄

@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Jun 3, 2017

@Fedik I applied the patch but I am still getting a plain select list.

image

@Fedik
Copy link
Copy Markdown
Member Author

Fedik commented Jun 3, 2017

@roland-d It will apply Chosen.js only if it available on the page, it do not force one.
I have tested in the Isis template params.

@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Jun 4, 2017

I have tested this item ✅ successfully on f5337c9

The dropdown was a regular select before the patch but after applying the patch it is now a chosen dropdown.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16471.

@N6REJ
Copy link
Copy Markdown
Contributor

N6REJ commented Jun 7, 2017

sorry I missed this, for some reason git is not emailing me with notices.. I'll get this tested in next 72hrs

@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Jul 4, 2017

@N6REJ The 72 hours are up, are you able to test this again?

@ghost
Copy link
Copy Markdown

ghost commented Jul 20, 2017

@N6REJ can you please test?

@N6REJ
Copy link
Copy Markdown
Contributor

N6REJ commented Jul 24, 2017

sorry guys, idk why but github refuses to send me notification for joomla. I get them for neard but not from joomla. I keep forgetting to get this done.. I"m going to leave the tab open so I don't forget.. give me 30 min.

@N6REJ
Copy link
Copy Markdown
Contributor

N6REJ commented Jul 24, 2017

I have tested this item ✅ successfully on f5337c9

This worked very nicely. RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16471.

@ghost
Copy link
Copy Markdown

ghost commented Jul 24, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 24, 2017
@zero-24 zero-24 added this to the Joomla 3.8.0 milestone Jul 24, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 25, 2017
roland-d added a commit to roland-d/joomla-cms that referenced this pull request Jul 26, 2017
@roland-d
Merge branch 'staging' into redo-7259-modal-for-quicker-edit
5adcaee 
* staging: (274 commits)
  Add JCryptCipherSodium to support libsodium (joomla#16754)
  Performance 2 (libraries/legacy) (joomla#12220)
  Performance 6 (templates) (joomla#12233)
  Fixed typehint (joomla#16425)
  Fix for: Repeatable field is no longer rendered with Chosen layout (joomla#16471)
  Fix the path for the ajax-loader.gif (joomla#16701)
  Menu items list parent filter (joomla#17060)
  Text Filters layout (joomla#17113)
  mod_login showon option (joomla#17153)
  com_banners incorret tooltip (joomla#17157)
  fix joomla.content.options_default (joomla#17123)
  remove the never working limitstart call (joomla#17184)
  Update phpDocumentor build
  set 3.8.0 Dev State
  Prepare 3.7.4 Stable Release
  fixed a logic change in joomla#12294, thanks @Hoffi1
  Update sv-SE.ini
  Update pt-BR.ini
  Update lv-LV.ini
  Update fa-IR.ini
  ...
@Fedik Fedik deleted the fix-chosen-repetable branch July 26, 2017 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laoneo laoneo laoneo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.8.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Fedik @roland-d @N6REJ @laoneo @mbabker @zero-24 @joomla-cms-bot