Merged
Conversation
At some point in the past when layouts were added the design of the global configuration text filters was changed and it looks odd This PR adds a new layoout just for text filters without the big empty space
|
I have tested this item ✅ successfully on 1ee6f69 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17113. |
zero-24
previously requested changes
Jul 13, 2017
Contributor
zero-24
left a comment
There was a problem hiding this comment.
Please use this:
<fieldset class="<?php echo !empty($displayData->formclass) ? $displayData->formclass : 'form-horizontal'; ?>">
<legend><?php echo $displayData->name; ?></legend>
<?php if (!empty($displayData->description)) : ?>
<p><?php echo $displayData->description; ?></p>
<?php endif; ?>
<?php $fieldsnames = explode(',', $displayData->fieldsname); ?>
<?php foreach ($fieldsnames as $fieldname) : ?>
<?php foreach ($displayData->form->getFieldset($fieldname) as $field) : ?>
<div><?php echo $field->input; ?></div>
<?php endforeach; ?>
<?php endforeach; ?>
</fieldset>
Contributor
Author
|
Why have every PHP line wrapped in ?PHP I just took the existing layout and removed the things we don't need here. |
Contributor
because it is a layout file ;) And this is supposed to have that ;) |
Contributor
|
Where is this file so i can correct it there too :) |
Contributor
Author
|
Joomla.contemt.options_default |
Member
|
@brianteeman check out the section on layouts: https://developer.joomla.org/coding-standards/php-code.html |
Contributor
Author
|
I was only working from an existing layout :( I will update it as requested |
Contributor
|
I have done the original too #17123 |
Contributor
Author
|
can this be retested please |
|
I have tested this item ✅ successfully on d3b2a52 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17113. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on d3b2a52 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17113. |
|
RTC after two successful tests. |
roland-d
added a commit
to roland-d/joomla-cms
that referenced
this pull request
Jul 26, 2017
* staging: (274 commits) Add JCryptCipherSodium to support libsodium (joomla#16754) Performance 2 (libraries/legacy) (joomla#12220) Performance 6 (templates) (joomla#12233) Fixed typehint (joomla#16425) Fix for: Repeatable field is no longer rendered with Chosen layout (joomla#16471) Fix the path for the ajax-loader.gif (joomla#16701) Menu items list parent filter (joomla#17060) Text Filters layout (joomla#17113) mod_login showon option (joomla#17153) com_banners incorret tooltip (joomla#17157) fix joomla.content.options_default (joomla#17123) remove the never working limitstart call (joomla#17184) Update phpDocumentor build set 3.8.0 Dev State Prepare 3.7.4 Stable Release fixed a logic change in joomla#12294, thanks @Hoffi1 Update sv-SE.ini Update pt-BR.ini Update lv-LV.ini Update fa-IR.ini ...
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point in the past (3.6.5?) when layouts were added the design of the global configuration text filters was changed and it looks odd
This PR adds a new layout just for text filters without the big empty space
Pull Request for Issue #15423
Before
After