Fix the path for the spinning logo ajax-loader.gif#15529
Closed
dgrammatiko wants to merge 2 commits intojoomla:stagingfrom
dgrammatiko:####core_js
Closed
Fix the path for the spinning logo ajax-loader.gif#15529dgrammatiko wants to merge 2 commits intojoomla:stagingfrom dgrammatiko:####core_js
dgrammatiko wants to merge 2 commits intojoomla:stagingfrom
dgrammatiko:####core_js
Conversation
Contributor
|
I have tested this item 🔴 unsuccessfully on 8745f48 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15529. |
|
Open without PR an Article, Tab "Content" or Tab "Fields", got in Console/JS: Use of getAttributeNode() is deprecated. Use getAttribute() instead. jquery-migrate.min.js:2:1714 System information3.7.1-rc1 MAMP 4.1.1
|
Fedik
reviewed
May 13, 2017
| } | ||
|
|
||
| // Define the base path as a string | ||
| JText::script('JOOMLA_BASE_PATH', JURI::root(true)); |
Member
There was a problem hiding this comment.
JFactory::getDocument()
->addScriptOptions('core.root', JUri::root(true))
->addScriptOptions('core.base', JUri::base(true));or joomla.root, whatever 😉
Contributor
Author
There was a problem hiding this comment.
@Fedik sure, that looks more appropriate
Contributor
|
I can confirm the problem on Joomla! 3.7.2-Dev (nightly Build) |
Contributor
|
after applying the patch all i get anywhere is |
This was referenced Jun 2, 2017
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #15305 .
Summary of Changes
Using data attributes for passing php data to javascript is totally fine (and very welcome) but in this particular occasion we need another way, since all the front end templates either need to update to echo this data attribute (not very likely to happen) or will not work.
So lets use the language strings (since what we're passing is just a word/string)...
Testing Instructions
Create a com_content custom field and edit an article from the front end.
Expected result
Actual result
no errorSpinning logo appears correctly, no error 404 not found in the browser's console
Documentation Changes Required
Nope