[LB policies] revert changes for dualstack design#33718
Merged
Conversation
…ld in updates (grpc#33568)" This reverts commit 21f2eba.
…ctivity state (grpc#33427)" This reverts commit 51e54ed.
…nnels directly (grpc#33093)" This reverts commit f09357c.
…directly (grpc#33087)" This reverts commit 38816cf.
…hannels directly (grpc#32692)" This reverts commit 27a778f.
ctiller
approved these changes
Jul 14, 2023
markdroth
added a commit
to markdroth/grpc
that referenced
this pull request
Jul 14, 2023
This reverts commit 083bbee.
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 27, 2023
This reverts the following PRs: grpc#32692 grpc#33087 grpc#33093 grpc#33427 grpc#33568 These changes seem to have introduced some flaky crashes. Reverting while I investigate.
markdroth
added a commit
that referenced
this pull request
Aug 31, 2023
This rolls forward only the pick_first changes from #32692, which were rolled back in #33718. Specifically: - Changes PF to use its own subchannel list implementation instead of using the subchannel_list library, since the latter will be going away with the dualstack changes. - As a result of no longer using the subchannel_list library, PF no longer needs to set the `GRPC_ARG_INHIBIT_HEALTH_CHECKING` channel arg. - Adds an option to start a health watch on the chosen subchannel, to be used in the future when pick_first is the child of a petiole policy. (Currently, this code is not actually called anywhere.)
This was referenced Aug 31, 2023
markdroth
added a commit
that referenced
this pull request
Sep 5, 2023
…34222) Rolls forward part of the dualstack changes, mostly from #33427 and a little bit from #32692, both of which were reverted in #33718. Specifically: - For petiole policies, unconditionally start health watch on subchannels, even if client side health checking is not enabled; in this case, the health watch will report the subchannel's raw connectivity state. - Fix edge cases in health check reporting that occur when a watcher is started before the initial state is reported. - When client-side health checking fails, add the subchannel's address to the RPC failure status message. - Outlier detection now works only via the health checking watch, not via the raw connectivity state watch. - Remove now-unnecessary hack to ensure that outlier detection does not work for pick_first.
markdroth
added a commit
that referenced
this pull request
Sep 7, 2023
markdroth
added a commit
that referenced
this pull request
Sep 11, 2023
markdroth
added a commit
that referenced
this pull request
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the following PRs: #32692 #33087 #33093 #33427 #33568
These changes seem to have introduced some flaky crashes. Reverting while I investigate.