[ring hash] delegate to pick_first instead of creating subchannels directly#33093
Merged
Conversation
…nt_data_watcher_new
…nt_data_watcher_new
…nt_data_watcher_new
…nt_data_watcher_new
…nt_data_watcher_new
eugeneo
approved these changes
Jun 27, 2023
| if (lowp > highp) { | ||
| first_index = 0; | ||
| index = 0; | ||
| break; |
Contributor
There was a problem hiding this comment.
nit: Unnecessary break (unless I miscounted the braces)
Member
Author
There was a problem hiding this comment.
I think this is correct. This breaks out of the while loop started on line 325.
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 13, 2023
…rectly (grpc#33093) More work on the dualstack backend design: - Change ring_hash policy to delegate to pick_first instead of creating subchannels directly. - Note that, as mentioned in the WIP gRFC, because we lazily create the pick_first child policies, so there's no need to swap over to a new list as an atomic whole. As a result, we don't use the endpoint_list library in this policy; instead, we just update a map in-place. - Remove now-unused subchannel_list library.
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 13, 2023
…dates (grpc#33568) I missed this in grpc#33093.
markdroth
added a commit
to markdroth/grpc
that referenced
this pull request
Jul 14, 2023
…nnels directly (grpc#33093)" This reverts commit f09357c.
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 27, 2023
This reverts the following PRs: grpc#32692 grpc#33087 grpc#33093 grpc#33427 grpc#33568 These changes seem to have introduced some flaky crashes. Reverting while I investigate.
This was referenced Sep 2, 2023
markdroth
added a commit
that referenced
this pull request
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More work on the dualstack backend design: