Skip to content

[WRR] delegate to pick_first instead of creating subchannels directly#33087

Merged
markdroth merged 104 commits into
grpc:masterfrom
markdroth:dualstack2
Jun 27, 2023
Merged

[WRR] delegate to pick_first instead of creating subchannels directly#33087
markdroth merged 104 commits into
grpc:masterfrom
markdroth:dualstack2

Conversation

@markdroth

@markdroth markdroth commented May 11, 2023

Copy link
Copy Markdown
Member

As part of the dualstack backend design, change WRR to delegate to pick_first instead of creating subchannels directly.

markdroth and others added 30 commits March 23, 2023 17:58
@markdroth markdroth marked this pull request as ready for review June 27, 2023 17:10
@markdroth markdroth requested a review from eugeneo June 27, 2023 17:11
@markdroth markdroth merged commit 38816cf into grpc:master Jun 27, 2023
@copybara-service copybara-service Bot added the imported Specifies if the PR has been imported to the internal repository label Jun 27, 2023
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 13, 2023
…grpc#33087)

As part of the dualstack backend design, change WRR to delegate to
pick_first instead of creating subchannels directly.
markdroth added a commit to markdroth/grpc that referenced this pull request Jul 14, 2023
markdroth added a commit that referenced this pull request Jul 14, 2023
This reverts the following PRs: #32692 #33087 #33093 #33427 #33568

These changes seem to have introduced some flaky crashes. Reverting
while I investigate.
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 27, 2023
This reverts the following PRs: grpc#32692 grpc#33087 grpc#33093 grpc#33427 grpc#33568

These changes seem to have introduced some flaky crashes. Reverting
while I investigate.
markdroth added a commit that referenced this pull request Sep 18, 2023
Rolls forward the changes from #33087, which were rolled back in #33718.

This change is now guarded by a disablable experiment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat/improvement imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants