Skip to content

[ring_hash] fix propagation of channel args to pick_first child in updates#33568

Merged
markdroth merged 2 commits into
grpc:masterfrom
markdroth:dualstack4.5
Jun 28, 2023
Merged

[ring_hash] fix propagation of channel args to pick_first child in updates#33568
markdroth merged 2 commits into
grpc:masterfrom
markdroth:dualstack4.5

Conversation

@markdroth

@markdroth markdroth commented Jun 28, 2023

Copy link
Copy Markdown
Member

I missed this in #33093.

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Jun 28, 2023
@markdroth markdroth requested a review from eugeneo June 28, 2023 18:39
@markdroth markdroth merged commit 21f2eba into grpc:master Jun 28, 2023
@markdroth markdroth deleted the dualstack4.5 branch June 28, 2023 23:51
@copybara-service copybara-service Bot added the imported Specifies if the PR has been imported to the internal repository label Jun 29, 2023
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 13, 2023
@markdroth @mario-vimal
[ring_hash] fix propagation of channel args to pick_first child in up…
4129cf9 
…dates (grpc#33568)

I missed this in grpc#33093.
markdroth added a commit to markdroth/grpc that referenced this pull request Jul 14, 2023
@markdroth
Revert "[ring_hash] fix propagation of channel args to pick_first chi…
2712c82 
…ld in updates (grpc#33568)"

This reverts commit 21f2eba.
@markdroth markdroth mentioned this pull request Jul 14, 2023
Merged
markdroth added a commit that referenced this pull request Jul 14, 2023
@markdroth
[LB policies] revert changes for dualstack design (#33718)
083bbee 
This reverts the following PRs: #32692 #33087 #33093 #33427 #33568

These changes seem to have introduced some flaky crashes. Reverting
while I investigate.
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 27, 2023
@markdroth @mario-vimal
[LB policies] revert changes for dualstack design (grpc#33718)
0ae55b0 
This reverts the following PRs: grpc#32692 grpc#33087 grpc#33093 grpc#33427 grpc#33568

These changes seem to have introduced some flaky crashes. Reverting
while I investigate.
@markdroth markdroth mentioned this pull request Sep 2, 2023
Merged
markdroth added a commit that referenced this pull request Sep 7, 2023
@markdroth
[ring_hash] delegate to pick_first as per dualstack design (#34244)
a315171 
Rolls forward the changes from #33093 and some from #33568, which were
rolled back in #33718.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eugeneo eugeneo eugeneo approved these changes

Assignees

No one assigned

Labels

bloat/low imported Specifies if the PR has been imported to the internal repository lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markdroth @eugeneo