Skip to content

[outlier detection] remove support for ejection via raw connectivity state#33427

Merged
markdroth merged 135 commits into
grpc:masterfrom
markdroth:dualstack4
Jun 28, 2023
Merged

[outlier detection] remove support for ejection via raw connectivity state#33427
markdroth merged 135 commits into
grpc:masterfrom
markdroth:dualstack4

Conversation

@markdroth

@markdroth markdroth commented Jun 13, 2023

Copy link
Copy Markdown
Member

More work on the dualstack backend design:

markdroth and others added 30 commits March 23, 2023 17:58
@markdroth markdroth marked this pull request as ready for review June 28, 2023 13:55
@markdroth markdroth requested a review from eugeneo June 28, 2023 13:55
@markdroth markdroth merged commit 51e54ed into grpc:master Jun 28, 2023
@markdroth markdroth deleted the dualstack4 branch June 28, 2023 15:44
@copybara-service copybara-service Bot added the imported Specifies if the PR has been imported to the internal repository label Jun 28, 2023
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 13, 2023
…state (grpc#33427)

More work on the dualstack backend design:
- Now that all petiole policies have been changed to delegate to
pick_first, outlier detection no longer needs to eject via the
subchannel's raw connectivity state; it can now eject only via the
health state. See grpc#33340.
- This also removes the now-unnecessary hack to explicitly disable
outlier detection in pick_first. See grpc#33336.
markdroth added a commit to markdroth/grpc that referenced this pull request Jul 14, 2023
markdroth added a commit that referenced this pull request Jul 14, 2023
This reverts the following PRs: #32692 #33087 #33093 #33427 #33568

These changes seem to have introduced some flaky crashes. Reverting
while I investigate.
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 27, 2023
This reverts the following PRs: grpc#32692 grpc#33087 grpc#33093 grpc#33427 grpc#33568

These changes seem to have introduced some flaky crashes. Reverting
while I investigate.
markdroth added a commit that referenced this pull request Sep 5, 2023
…34222)

Rolls forward part of the dualstack changes, mostly from #33427 and a
little bit from #32692, both of which were reverted in #33718.
Specifically:
- For petiole policies, unconditionally start health watch on
subchannels, even if client side health checking is not enabled; in this
case, the health watch will report the subchannel's raw connectivity
state.
- Fix edge cases in health check reporting that occur when a watcher is
started before the initial state is reported.
- When client-side health checking fails, add the subchannel's address
to the RPC failure status message.
- Outlier detection now works only via the health checking watch, not
via the raw connectivity state watch.
- Remove now-unnecessary hack to ensure that outlier detection does not
work for pick_first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat/improvement imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants