Skip to content

[health checking] move to generic health watch for dualstack design#34222

Merged
markdroth merged 3 commits into
grpc:masterfrom
markdroth:dualstack_pf_plus_health_watch
Sep 5, 2023
Merged

[health checking] move to generic health watch for dualstack design#34222
markdroth merged 3 commits into
grpc:masterfrom
markdroth:dualstack_pf_plus_health_watch

Conversation

@markdroth

Copy link
Copy Markdown
Member

Rolls forward part of the dualstack changes, mostly from #33427 and a little bit from #32692, both of which were reverted in #33718. Specifically:

  • For petiole policies, unconditionally start health watch on subchannels, even if client side health checking is not enabled; in this case, the health watch will report the subchannel's raw connectivity state.
  • Fix edge cases in health check reporting that occur when a watcher is started before the initial state is reported.
  • When client-side health checking fails, add the subchannel's address to the RPC failure status message.
  • Outlier detection now works only via the health checking watch, not via the raw connectivity state watch.
  • Remove now-unnecessary hack to ensure that outlier detection does not work for pick_first.

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Aug 31, 2023
@markdroth markdroth requested a review from eugeneo August 31, 2023 22:09
Automated fix for refs/heads/dualstack_pf_plus_health_watch
@markdroth markdroth merged commit b7e680a into grpc:master Sep 5, 2023
@markdroth markdroth deleted the dualstack_pf_plus_health_watch branch September 5, 2023 17:17
@copybara-service copybara-service Bot added the imported Specifies if the PR has been imported to the internal repository label Sep 5, 2023
@ti-chi-bot ti-chi-bot Bot mentioned this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat/improvement imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants