Skip to content

[round_robin] delegate to pick_first as per dualstack design#34241

Merged
markdroth merged 8 commits into
grpc:masterfrom
markdroth:dualstack_rr
Sep 11, 2023
Merged

[round_robin] delegate to pick_first as per dualstack design#34241
markdroth merged 8 commits into
grpc:masterfrom
markdroth:dualstack_rr

Conversation

@markdroth

@markdroth markdroth commented Sep 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Rolls forward the remaining changes from #32692, which were rolled back in #33718.

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Sep 1, 2023
@markdroth markdroth mentioned this pull request Sep 2, 2023
Merged
@markdroth markdroth marked this pull request as ready for review September 5, 2023 17:35
@markdroth markdroth requested a review from eugeneo September 5, 2023 17:35
@markdroth markdroth merged commit 97571eb into grpc:master Sep 11, 2023
@markdroth markdroth deleted the dualstack_rr branch September 11, 2023 19:10
@copybara-service copybara-service Bot added the imported Specifies if the PR has been imported to the internal repository label Sep 11, 2023
ctiller added a commit that referenced this pull request Sep 12, 2023
@ctiller
Revert "[round_robin] delegate to pick_first as per dualstack design (#…
d39ba54 
…34241)"

This reverts commit 97571eb.
@ctiller ctiller mentioned this pull request Sep 12, 2023
Merged
ctiller added a commit that referenced this pull request Sep 12, 2023
@ctiller
Revert "[round_robin] delegate to pick_first as per dualstack design" (…
e6bf7c1 
…#34317)

Reverts #34241
@markdroth markdroth mentioned this pull request Sep 12, 2023
Merged
markdroth added a commit that referenced this pull request Sep 13, 2023
@markdroth
[round_robin] third attempt: delegate to pick_first as per dualstack …
d713427 
…design (#34320)

Previous attempt was #34241, reverted in #34317.

The second commit here makes the experiment disablable, so that we can
roll it out slowly internally.
@ti-chi-bot ti-chi-bot Bot mentioned this pull request Jul 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eugeneo eugeneo eugeneo approved these changes

+1 more reviewer

@hexiaokang hexiaokang hexiaokang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bloat/low imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markdroth @eugeneo @hexiaokang