Skip to content

[round_robin] third attempt: delegate to pick_first as per dualstack design#34320

Merged
markdroth merged 3 commits into
grpc:masterfrom
markdroth:dualstack_rr_rollforward
Sep 13, 2023
Merged

[round_robin] third attempt: delegate to pick_first as per dualstack design#34320
markdroth merged 3 commits into
grpc:masterfrom
markdroth:dualstack_rr_rollforward

Conversation

@markdroth

@markdroth markdroth commented Sep 12, 2023

Copy link
Copy Markdown
Member

Previous attempt was #34241, reverted in #34317.

The second commit here makes the experiment disablable, so that we can roll it out slowly internally.

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Sep 12, 2023
@markdroth markdroth marked this pull request as ready for review September 12, 2023 15:18
@markdroth markdroth requested a review from ctiller September 12, 2023 15:18
@markdroth markdroth merged commit d713427 into grpc:master Sep 13, 2023
@markdroth markdroth deleted the dualstack_rr_rollforward branch September 13, 2023 00:46
markdroth added a commit that referenced this pull request Sep 13, 2023
ctiller pushed a commit that referenced this pull request Sep 13, 2023
@copybara-service copybara-service Bot added the imported Specifies if the PR has been imported to the internal repository label Sep 13, 2023
markdroth added a commit that referenced this pull request Sep 14, 2023
…sign (#34337)

Most recent attempt was #34320, reverted in #34335.

The first commit here is a pure revert. The second commit fixes the
outlier_detection unit test to pass both with and without the
experiment.
@ti-chi-bot ti-chi-bot Bot mentioned this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat/medium imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants