Conversation
PB-360: Fix GPX layer printing issue
…leset BGDIDIC-2749: poc with a master tileset for the vegetation
Also use the correct endpoint instead of the default endpoint.
…kend-revert PB-397: Revert back print backend to correct staging on DEV
…try-button PB-424: Time slider year entry button
Some layers id might be of 3 words separated by dot (e.g. ch.bfe.energieforschung) which could also be a valid what3words address, therefore we need a fallback to service search. Of course now we still the issue if a valid what3words is also a valid layer ID, the search will always jump to the what3words location, but hopefully this is quite un-probable.
PB-426: Fallback to service search for invalid what3words
The attribution (copyright) on the pdf was empty. Also add the background layer attribution if any background.
We could duplicate some layers with different opacity, but when printing we need to make sure to have their legend only once.
Added attribution, language and filename tests. Also tested duplicate layer in print.
PB-389: Fix print attributions and duplicate legends
Add the 'isTimeSliderActive' parameter in the UI store. This parameter will be used to activate the time slider and to store the time slider year between use, in a way similar to the compare slider. Add the 'timeSlider' URL parameter which will activate the time slider if there is at least one time enabled layer visible. PB-320: time slider no longer reset 'previewYear' as the time slider won't be activated by previewYear, we are no longer resetting previewYear also moved youngest year and oldest year to the config, as it's used both in the URL parameter class and the time slider PB-320: Using isTimeSliderActive in the code Used isTimeSliderActive parameter for time slider activation, keeping the previewYear in memory between activations.
small tests update
as there's already a helper function there to decide if the geometry is profile able/worthy
…ot-updated-when-moved PB-482: Elevation profile not updated when moved
pakb
approved these changes
May 6, 2024
Passing run #2046 ↗︎Details:
Review all test suite changes for PR #822 ↗︎ |
|||||||||||||||
When building locally we could not deploy the build on a S3 bucket due to `+` sign in the version folder. `+` should be percent encoded otherwise the web server will change it to space. For simplification we change the plus to hypen.
PB-435: Added help link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link