Conversation
|
@stebie @hansmannj @Luke252 should we use the correct link directly for the help button in the viewer ? Instead of the old help.geo.admin.ch ? So we can handle the language properly. Otherwise we would need to use the service-redirect for the go live to redirect the request correctly. It might be easier to simply put the correct URL here, only on the new viewer. |
Passing run #2044 ↗︎
Details:
Review all test suite changes for PR #812 ↗︎ |
|||||||||||||||
ltkum
left a comment
There was a problem hiding this comment.
looking at the code and after testing, I don't see anything wrong here. Once we've decided on a link, you can go ahead and merge.
hansmannj
left a comment
There was a problem hiding this comment.
Thanks. LGMT 👍
Not sure about how to handle the language with the new CMS though.
If I correctly understood, there's no URL param for the language anymore, but a different path per language, right?
When building locally we could not deploy the build on a S3 bucket due to `+` sign in the version folder. `+` should be percent encoded otherwise the web server will change it to space. For simplification we change the plus to hypen.
Test link