PB-426: Fallback to service search for invalid what3words#790
Merged
Conversation
Passing run #1806 ↗︎
Details:
Review all test suite changes for PR #790 ↗︎ |
|||||||||||||||
ea60cda to
a0d0126
Compare
Some layers id might be of 3 words separated by dot (e.g. ch.bfe.energieforschung) which could also be a valid what3words address, therefore we need a fallback to service search. Of course now we still the issue if a valid what3words is also a valid layer ID, the search will always jump to the what3words location, but hopefully this is quite un-probable.
a0d0126 to
3eda4ed
Compare
pakb
approved these changes
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some layers id might be of 3 words separated by dot (e.g. ch.bfe.energieforschung)
which could also be a valid what3words address, therefore we need a fallback
to service search.
Of course now we still the issue if a valid what3words is also a valid layer
ID, the search will always jump to the what3words location, but hopefully this
is quite un-probable.
Test link