PB-389: Fix print attributions and duplicate legends#793
Merged
Conversation
Passing run #1818 ↗︎
Details:
Review all test suite changes for PR #793 ↗︎ |
|||||||||||||||
6a953eb to
fa22b17
Compare
The attribution (copyright) on the pdf was empty. Also add the background layer attribution if any background.
We could duplicate some layers with different opacity, but when printing we need to make sure to have their legend only once.
Added attribution, language and filename tests. Also tested duplicate layer in print.
fa22b17 to
a3e8975
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribution (copyright) on the pdf was empty.
Also add the background layer attribution if any background.
Fix duplicate print legends. We could duplicate some layers with different opacity, but when printing we need to make sure to have their legend only once.
Added attribution, language and filename tests. Also tested duplicate layer
in print.
Test link