PB-482: Elevation profile not updated when moved#821
Merged
Conversation
Passing run #2037 ↗︎
Details:
Review all test suite changes for PR #821 ↗︎ |
|||||||||||||||
ed5e30f to
2af977d
Compare
2af977d to
1780d61
Compare
ltshb
approved these changes
May 6, 2024
pakb
reviewed
May 6, 2024
Comment on lines
+105
to
+110
| if ( | ||
| storeFeature.geometry.type === 'Polygon' || | ||
| storeFeature.geometry.type === 'LineString' | ||
| ) { | ||
| store.dispatch('setProfileFeature', { feature: storeFeature, ...dispatcher }) | ||
| } |
Contributor
There was a problem hiding this comment.
I'd maybe move that to features.store.js changeFeatureGeometry action where there's already a canFeatureShowProfile() helper function that could be used to check for geometry type,
and so that it is triggered whenever the geometry changes (not only through this modify interaction)
Contributor
There was a problem hiding this comment.
As Lukas is "under the flags" for the foreseeable month, I'll do the change myself
as there's already a helper function there to decide if the geometry is profile able/worthy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link