PB-397: Revert back print backend to correct staging on DEV#772
Merged
PB-397: Revert back print backend to correct staging on DEV#772
Conversation
Passing run #1793 ↗︎
Details:
Review all test suite changes for PR #772 ↗︎ |
|||||||||||||||
6ce2ada to
89d4d26
Compare
hansmannj
reviewed
Apr 9, 2024
Member
There was a problem hiding this comment.
Just noticed something:
service-print3 seems to always have some kind of default setting. Not sure, if it can be deleted/suppressed. Maybe @marionb knows?
In our case, default seems to match our specific config, as there is only one. But it might be better ot explicilty use our configuration. Hence the endpoint would be:
/print3/print/mapviewer/ instead of /print3/print/default/
(also see: https://github.com/geoadmin/service-print3/tree/develop/print-apps/mapviewer)
947028c to
e632684
Compare
Also use the correct endpoint instead of the default endpoint.
e632684 to
3f57a1f
Compare
Contributor
Author
|
The DEV staging seems to work again, no idea why it hangs in the past needs to keep an eye on it. I also enabled the e2e tests for print see https://github.com/geoadmin/infra-e2e-tests/pull/279 |
LukasJoss
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link