BGDIDIC-2749: poc with a master tileset for the vegetation#759
Merged
BGDIDIC-2749: poc with a master tileset for the vegetation#759
Conversation
Passing run #1782 ↗︎
Details:
Review all test suite changes for PR #759 ↗︎ |
|||||||||||||||
cf8de03 to
1a9bab5
Compare
Contributor
Author
|
@here topo is happy with this configuration and they agree to go live as this. We will have to implement a 3D layer Menu with shadow slider etc. post go-live. I need some help with the cypress tests |
ltshb
approved these changes
Apr 18, 2024
Comment on lines
378
to
+380
| // increases the LOD (Cesium will load one tile further down the zoom pyramid) => higher rez WMTS | ||
| globe.maximumScreenSpaceError = 0.5 | ||
| //globe.maximumScreenSpaceError = 0.5 |
Contributor
There was a problem hiding this comment.
Better remove this as simply comment, or if it is just temporary please comment the reason of the temporary removal
Contributor
|
@rebert this cypress test is just a flaky one that come time to time. With @LukasJoss I'm trying to understand why it is flaky to solve this annoying flakiness, but for your PR simply retrigger a build will probably solve the issue. |
2376940 to
56044c4
Compare
56044c4 to
d25dc98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link