Skip to content

PB-360: Fix GPX layer printing issue#789

Merged
ismailsunni merged 4 commits intodevelopfrom
fix-PB-360-gpx-print-style
Apr 18, 2024
Merged

PB-360: Fix GPX layer printing issue#789
ismailsunni merged 4 commits intodevelopfrom
fix-PB-360-gpx-print-style

Conversation

@ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Apr 17, 2024

Issue

  • If we upload GPX layer with a point, it will be styled as white circle (should be red with black border as in the old viewer)
  • If the uploaded GPX layer has two different geometry, it will be styled with the same style (white circle)

The issue

Shown in the viewer:
image
Print result:
image

After Fix

Shown in the viewer:
image
Print result:
image

Test link

@github-actions github-actions bot added the bug label Apr 17, 2024
@cypress
Copy link

cypress bot commented Apr 17, 2024

Passing run #1777 ↗︎

0 162 19 0 Flakiness 0

Details:

Pb-360: Add white circle style for GPX layer.
Project: web-mapviewer Commit: 0c8e4ecd2c
Status: Passed Duration: 05:09 💡
Started: Apr 18, 2024 2:56 AM Ended: Apr 18, 2024 3:01 AM

Review all test suite changes for PR #789 ↗︎

@ismailsunni ismailsunni marked this pull request as ready for review April 17, 2024 08:03
@ismailsunni ismailsunni requested review from ltshb and pakb April 17, 2024 08:03
@ismailsunni ismailsunni force-pushed the fix-PB-360-gpx-print-style branch from 82bb25c to 0c8e4ec Compare April 18, 2024 02:53
@ismailsunni ismailsunni requested a review from ltshb April 18, 2024 03:06
@ismailsunni ismailsunni merged commit a151947 into develop Apr 18, 2024
@ismailsunni ismailsunni deleted the fix-PB-360-gpx-print-style branch April 18, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants