Skip to content

New Release v0.4.0 - #minor#327

Merged
procrastinatio merged 58 commits intomasterfrom
develop
Dec 20, 2022
Merged

New Release v0.4.0 - #minor#327
procrastinatio merged 58 commits intomasterfrom
develop

Conversation

@ltshb
Copy link
Contributor

@ltshb ltshb commented Dec 20, 2022

ltshb and others added 30 commits November 24, 2022 20:25
Sometimes the mouseposition test failed due to null coordinate.
Set fallback to non short url in case the backend service is not available.
Added a parser that can generate an editable feature from an olFeature
that was just created from a KML file.
The old viewer now recognizes the feature types if it reads a kml file
generated by the new viewer.
…wer.

Parse the icon url format from the old viewer to recreate the editable
feature. Also added some comments.
- Editable feature and ol feature now share the same id, so that it is
  not necessary to do string transformations to translate between the
  two.
- When importing an old kml, the old id format is translated to the new
  id format when importing
- Now the id is generated using a timestamp. This should reduce the
  chances of collision.
- set coordinates an id correctly on olFeature
- added a new text size to be compatible with the old viewer
- added documentation
Reversed the fix for backward compatibility, as it caused some issues
and was not needed, as we only want to support forward compatibility.
Moving all legacy KML utils function into a dedicated file, also moving along related tests
Removing the import of the store in the utils function and passing requirements as params instead

Renaming Icon class into DrawingIcon (and DrawingIconSet instead of IconSet) in order not to mix match the name with OpenLayers Icon class
Renaming default Feature class into SelectableFeature, same as above, so that it does not collide with OpenLayers Feature class (and having one word class name is a bad practice anyway)
This border is needed to increase contrast on hell background otherwise we
don't see the position triangle on light background.
For some unknown reason I had the `clipboard.writeText` that failed on rare
occasion while testing locally. This broke the application. Therefore I
added some error handling.
Removed the 8px gap between the qrcode and the share link in location popup.
Some what3words are long and cause the copy button to be pushed in a new line.
To avoid this and keep the copy button on the same line, we use the text overflow
ellipsis. To achieve this we also reduced the labels column width to a minimum
to get more space for the what3words. In case of long what3words the word
is now truncated with elipsis (...) but you can still copy the whole name using
the copy button. Most of the time the word is not truncated.
The copy buttons in the position popup where lightly overlapped, adding a small
gap between row fixed that issue.
ltshb and others added 25 commits November 30, 2022 09:38
Some GeoJSON layers were not displayed correctly. Styling with a geometry type
of `point` where not displayed due to a wrong string comparison (`'point' === 'Point'`)

Also sometimes we could have a crash due to a non existing layer object which
was due to the fact that when hovering a search result a layer is created and
asynchronously the layer style was loaded, meanwhile when the hover is gone
the layer is destroyed which can happen before the layer style load from backend.

Updated some missing event in emit list to prevents vue warning.
We could not select GeoJSON layer feature on the map. The issue was due to
wrong layerFilter in the OpenLayersMap.

Then once the feature selection was fixed the position was not correctly
marked as selected due to the wrong coordinates in the features.api were
the setter was not called.

Finally the content of the popup was wrong due to the missing feature name
in the LayerFeature.
The popover triangle css declaration was done in two component, one used
a border but the other not. Moved it to the parent component with the border.

This way both html popover and position popover use the same triangle style.
Made it similar to mf-geoadmin3. For this I removed the card-body class that
added padding that we don't want on html popup to have the title in a grey
bar taking the whole width of the bar.

I kept the card-body for the position popup.
Instead of using a margin use a paddind of the htmlpopup content. This avoid
to have the content of the card.
The modal view with the black drop did not took the whole screen but only the
size of the modal window. Also improved padding and margin for modal window
On Mobile the drawing share input group were displayed on two lines and the
modal window took only about 50-60% of the view.

This has been solved by setting on mobile the width of the modal view to 90% of
the view.
This match the style of the main menu and also looks better on mobile view
where the menu takes the whole width of the screen.

A further improvement would be to add some shadow as well as to the main menu.
The infobox takes the whole screen width therefore removed the rounded corner
as they are not looking nice on the whole screen.

Also reduced the size of the control button to have them the same as the tooltip
box
In infobox for html popup we don't want any padding while we need padding for
other infobox elements (drawing infos,...).

In the drawing popover the button margin was applied to all div elements instead
of just the buttons. This has been fixed.
When resizing the windows or on mobile when switching between portrait
and landscape, the method updateElevationProfilePlot() crashed because it is
executed within a promise and due to timing the refs.profilePlot might be null.
Fixed elevation profile crash on windows resize
…e site of the globe

In order to prevent a WMS layer from appearing twice, once in CH and
once close to New Zealand, pretty much the same fix as for WMTS was
applied. See: c689f9a
…bling_of_wms_layers_on_other_side_of_globe

Fix_BGDIINF_SB-2682 no more doubling of wms layers on other side of globe
…nners

BGDIINF_SB-2678 Made the test banner dynamic based on hostname
@github-actions github-actions bot changed the title a New Release v0.4.0 - #minor Dec 20, 2022
@ltshb ltshb requested a review from procrastinatio December 20, 2022 13:17
Copy link
Contributor

@procrastinatio procrastinatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks to all.

@procrastinatio procrastinatio merged commit 5af3ebe into master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants