Fixed elevation profile crash on windows resize#317
Merged
Conversation
935ab34 to
8917ccf
Compare
pakb
approved these changes
Dec 1, 2022
Contributor
pakb
left a comment
There was a problem hiding this comment.
I hope my refactoring hasn't brought up more bugs, at least it's a bit clearer when we need to fix something now 😜
When resizing the windows or on mobile when switching between portrait and landscape, the method updateElevationProfilePlot() crashed because it is executed within a promise and due to timing the refs.profilePlot might be null.
8917ccf to
ef4514a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resizing the windows or on mobile when switching between portrait
and landscape, the method updateElevationProfilePlot() crashed because it is
executed within a promise and due to timing the refs.profilePlot might be null.
Test link