BGDIINF_SB-2662: Various bugfixes on position popup#310
Merged
Conversation
pakb
approved these changes
Nov 29, 2022
Contributor
pakb
left a comment
There was a problem hiding this comment.
Minor issues with logging, but not big of a deal
This border is needed to increase contrast on hell background otherwise we don't see the position triangle on light background.
For some unknown reason I had the `clipboard.writeText` that failed on rare occasion while testing locally. This broke the application. Therefore I added some error handling.
Removed the 8px gap between the qrcode and the share link in location popup.
Some what3words are long and cause the copy button to be pushed in a new line. To avoid this and keep the copy button on the same line, we use the text overflow ellipsis. To achieve this we also reduced the labels column width to a minimum to get more space for the what3words. In case of long what3words the word is now truncated with elipsis (...) but you can still copy the whole name using the copy button. Most of the time the word is not truncated.
The copy buttons in the position popup where lightly overlapped, adding a small gap between row fixed that issue.
Changed the label of the share link.
64e3e4b to
d11a7b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various bugfixes and improvements, see commits message for more details.
Now the Whats3word is truncated with ellipsis, but you can still copy the whole address with the copy button. The position label space has been also reduced to let more space for the values. This reduced the risk of what3words truncate which now happens quite rarely.
Here below is an example of a truncate what3words
Test link