Merged
Conversation
26bf052 to
17972ed
Compare
pakb
approved these changes
Nov 30, 2022
Contributor
pakb
left a comment
There was a problem hiding this comment.
something is weird with test (maybe) unrelated with your change in drawing/sharing
Contributor
Author
|
@pakb The test were brocken due to a display bug on mobile device for the share modal view. I fixed it with the last commit. I check all the following views look nice on mobile and desktop version (only checked with chrome though)
|
5efb12b to
190fe98
Compare
The modal view with the black drop did not took the whole screen but only the size of the modal window. Also improved padding and margin for modal window
On Mobile the drawing share input group were displayed on two lines and the modal window took only about 50-60% of the view. This has been solved by setting on mobile the width of the modal view to 90% of the view.
190fe98 to
934f896
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modal view with the black drop did not took the whole screen but only the
size of the modal window. Also improved padding and margin for modal window
Test link