BGDIINF_SB-2683: Improved html popover style#315
Merged
Conversation
b6cb499 to
b3c6b69
Compare
dc6c5a3 to
e730561
Compare
e730561 to
1fb774f
Compare
The popover triangle css declaration was done in two component, one used a border but the other not. Moved it to the parent component with the border. This way both html popover and position popover use the same triangle style.
Made it similar to mf-geoadmin3. For this I removed the card-body class that added padding that we don't want on html popup to have the title in a grey bar taking the whole width of the bar. I kept the card-body for the position popup.
Instead of using a margin use a paddind of the htmlpopup content. This avoid to have the content of the card.
b3c6b69 to
88ac4e0
Compare
pakb
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the style of html popup to match mf-geoadmin3:
Was before:
And now is:
Test link