BGDIINF_SB-2683: Fixed padding in infobox and popover#318
Merged
Conversation
This match the style of the main menu and also looks better on mobile view where the menu takes the whole width of the screen. A further improvement would be to add some shadow as well as to the main menu.
The infobox takes the whole screen width therefore removed the rounded corner as they are not looking nice on the whole screen. Also reduced the size of the control button to have them the same as the tooltip box
In infobox for html popup we don't want any padding while we need padding for other infobox elements (drawing infos,...). In the drawing popover the button margin was applied to all div elements instead of just the buttons. This has been fixed.
pakb
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In infobox for html popup we don't want any padding while we need padding for
other infobox elements (drawing infos,...).
In the drawing popover the button margin was applied to all div elements instead
of just the buttons. This has been fixed.
Test link