Merged
Conversation
1593c11 to
3355ae6
Compare
dc6c5a3 to
e730561
Compare
pakb
reviewed
Nov 30, 2022
Contributor
pakb
left a comment
There was a problem hiding this comment.
Not sure about this refactoring working as intended
Some GeoJSON layers were not displayed correctly. Styling with a geometry type of `point` where not displayed due to a wrong string comparison (`'point' === 'Point'`) Also sometimes we could have a crash due to a non existing layer object which was due to the fact that when hovering a search result a layer is created and asynchronously the layer style was loaded, meanwhile when the hover is gone the layer is destroyed which can happen before the layer style load from backend. Updated some missing event in emit list to prevents vue warning.
We could not select GeoJSON layer feature on the map. The issue was due to wrong layerFilter in the OpenLayersMap. Then once the feature selection was fixed the position was not correctly marked as selected due to the wrong coordinates in the features.api were the setter was not called. Finally the content of the popup was wrong due to the missing feature name in the LayerFeature.
e730561 to
1fb774f
Compare
pakb
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some GeoJSON layers were not displayed correctly. Styling with a geometry type
of
pointwhere not displayed due to a wrong string comparison ('point' === 'Point')Also sometimes we could have a crash due to a non existing layer object which
was due to the fact that when hovering a search result a layer is created and
asynchronously the layer style was loaded, meanwhile when the hover is gone
the layer is destroyed which can happen before the layer style load from backend.
Updated some missing event in emit list to prevents vue warning.
Test link