BGDIINF_SB-2678 Made the test banner dynamic based on hostname#322
Merged
procrastinatio merged 1 commit intodevelopfrom Dec 20, 2022
Merged
BGDIINF_SB-2678 Made the test banner dynamic based on hostname#322procrastinatio merged 1 commit intodevelopfrom
procrastinatio merged 1 commit intodevelopfrom
Conversation
4220477 to
fd3c3af
Compare
fd3c3af to
3401fee
Compare
ltshb
reviewed
Dec 12, 2022
Contributor
ltshb
left a comment
There was a problem hiding this comment.
The current big test banner should be not set based on configuration variable but on location hostname.
ed266f5 to
42aa6d3
Compare
42aa6d3 to
2daf3be
Compare
ltshb
reviewed
Dec 20, 2022
| line-height: 50px; | ||
| letter-spacing: 1px; | ||
| font-weight: bold; | ||
| font-size: 2em; |
Contributor
There was a problem hiding this comment.
I personally prefer without the font-size (maybe matter of taste):
With font-size 2em:
Without font-size:
Without looks more similar to the current ribbon banner on test.map.geo.admin.ch
Contributor
Author
There was a problem hiding this comment.
OK, as you want.
e47280d to
b3d5a86
Compare
ltshb
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display a warning ribbon like: https://test.map.geo.admin.ch/
The test link won't work as the ribbon is only shown if
DEV_SITE_WARNINGis set to False and the hostname is matchingWARNING_RIBBON_HOSTNAMES. Build locally and runnpm run preview(production preview)Test link