Conversation
…-help-text PB-540: Adapt help text for drawing
Issue : An overflow was causing two scroll bars to appear on Chromium browsers when using the 3D view. Fix : removed the fluid css condition and set a consistent max-height of 100%
Running pnpm run build:dev:watch permits the user to modify the geodamin package and updating the build so that the changes have direct effect on the running mapviewer. Note: I observed that the mapviewer updates the open page too fast, which makes it not load correctly and a reload of the page is sometimes needed.Add a build dev watch option to geoadmin packages
Updating all i18n translation JSON through the script (some values have been formatted or slightly changed because of that) Tweaking a bit the DrawingTooltip component so that it now properly shows the "Click to add a point" text when hover over a selected line/measure feature.
Fixing the issue: If the user shares the link from the 2D view, you can easily switch between 2D and 3D views after opening the link. However, if it shares the link from the 3D view, for example with a predefined view, and then switches to the 2D view, the WMS layers are not displayed. You first have to reload the map.
Issues : - We were sending 3 pairs of Coordinates to the format function while in 3D, and the function could only handle two - The is3DReady flag was sometimes ready before the viewer could be accessed, leading to a situation where the handler could not be set up Fixes : - We're splitting the coordinates and adding the rounded height at the end of it. (the height is optional IMO) - We set a timeOut function which call itself while the viewer is not ready to ensure the viewer is ready before we set the handler. meh PB-1595: ensuring reactivity works for 3D Issue: When going from 3d to 2d, then back to 3d, the `isViewerReady` flag stayed at true the whole time, stopping other components from watching its state. This could mean some components would see the flag as true when the viewer was not ready. Fix: We now set the flag to false when destroying the 3d viewer. We also removed the timeouts in the mouse position plugin. PB-1595: show webMercator labels Issue : the webMercator labels were not displayed Fix : we ensure the function display all labels
…ates-in-3D PB-1595: showing mouse coordinates in 3D:
PB-1606: Tooltip doesn't translate and needs some padding
We will move the generation of margin in the viewer, instead of dealing with that on the backend. This is because it's way easier to keep the "true-to-scale" when shrinking the map viewport (and let it recalculate everything) instead of resizing the flatten map and thus changing the scale of the image. Using CSS padding instead of margin, so that we respect the A4 size we previously calculated (if we use margin, it will extend the "page" size and break the A4 layout)
…int-margin PB-1522 : DPI responsive print margin
Fixed issue where under certain circumstances, a duplicate of a time layer with different years have trouble being compared.
- Issue : We want to remove the UI from the embed view in some cases, so when we are in käze, we can use the sites native UI. - Fix : We add an URL parameter whose role it is to remove these buttons.
only for embed mode
…-param-for-gps PB-1636: add parameter to remove UI in embed view
Issue : Whenever we loaded external layers with parameters in the base URL, we sometimes had issues where the base Url of the get Capabilities and the base URL of the layer were not the same, thus blocking the equality check that allowed the layer to update. This caused the layer to never show that it was ready, even when it was. Fix : When we update the external layer through its capabilities, if there was a baseUrl before, we set the baseUrl of the `updated` layer to the original one, ensuring the layer will be updated.
… ensure WMS supporting such a syntax are correctly supported in our viewer.
…ng-layers PB-1253: stop external layers to never be ready
Update libs
highlight current segment multi line profile
and not on the whole profile feature, when there's more than one segment
…le-segment PB-1179: Zoom-to-extent zooms on current profile segment
HTTP 404 - https://services.geo.sg.ch/wss/service/SG00008_WMS/guest? - https://services.geo.sg.ch/wss/service/SG00038_WMS/guest? - https://wms.geo.gr.ch/uebersichtsplan HTTP 500 - https://vogis.cnv.at/mapserver/mapserv?map=i_naturschutz_v_wms.map HTTP 403 - https://services.geo.sg.ch/wss/service/SG00019_WMS/guest? no CORS support - https://map.geo.tg.ch/proxy/geofy_chsdi3/hintergrundplan?access_key=YoW2syIQ4xe0ccJA - https://wms.pcn.minambiente.it/ogc?map=/ms_ogc/WMS_v1.3/raster/DTM_20M.map - https://wms.pcn.minambiente.it/ogc?map=/ms_ogc/WMS_v1.3/raster/IGM_100000.map - https://wms.pcn.minambiente.it/ogc?map=/ms_ogc/WMS_v1.3/raster/IGM_25000.map - https://wms.pcn.minambiente.it/ogc?map=/ms_ogc/WMS_v1.3/raster/IGM_250000.map - https://wms.pcn.minambiente.it/ogc?map=/ms_ogc/WMS_v1.3/raster/ortofoto_colore_06.map - https://wms.pcn.minambiente.it/ogc?map=/ms_ogc/WMS_v1.3/Vettoriali/Rete_ferroviaria.map - https://www.basemap.at/wmts/1.0.0/WMTSCapabilities.xml Malformed/invalid GetCapabilities response - https://services.geo.sg.ch/wss/service/SG00034_WMS/guest?
Looks like some recent changes (tailwind?) have broken the now old Vue2 component that was handling the collapse animation for the menu. There’s now alternative made in Vue3, we should migrate
The current setup wasn't working, so I added a new "mode" to Vite to differentiate when we run Cypress or when we develop. This is due to some test failing if the devtools are present (menuTray.cy.js is one example)
PB-1672: fix menu collapse
As pointed out by some of our users, the dynamically generated coordinates on the bottom right part of the map with the mouse are not precise when dealing with LV03. They are generated without taking into consideration the real deformation between LV95 and LV03, and are calculated based on a simple matrix reprojection to be more dynamic (we are not using the REFRAME service after each mouse move, that would be overkill).
…use-track PB-1670: clarify lack of precision of mouse tracked LV03 coordinates
The geolocation button has a "linking background" with the compass button (which isn't visible when pointing north). Since modularization, this background is swelling under the button also fixing an issue with the "share link" input, that was not expending as intended since the tooltip modularization. I also took the opportunity to only color the border of the input when a warning is shown, and moved the tooltip with the warning text to the copy button
PB-1674: Fix tooltip creating too much height with map buttons
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 06m 23s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
20
|
|
|
0
|
|
|
251
|
| View all changes introduced in this branch ↗︎ | |
adding some retry-ability to the tests so that it behaves better on the CI.
we were missing the little endian signature for BigTIFF (which is different than normal TIFFs) to be able to parse a local BigTIFF file. It was working fine with URLs already because we do not test against little endian signature in this case, and let GeoTIFF.js library do its magic, so nothing to change there.
sommerfe
approved these changes
May 12, 2025
schtibe
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link