PB-1253: stop external layers to never be ready#1314
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 23s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
5da3917 to
3305c85
Compare
pakb
reviewed
Apr 28, 2025
Contributor
pakb
left a comment
There was a problem hiding this comment.
Can you add a test to cover this ?
Contributor
Author
yes |
pakb
approved these changes
Apr 29, 2025
Issue : Whenever we loaded external layers with parameters in the base URL, we sometimes had issues where the base Url of the get Capabilities and the base URL of the layer were not the same, thus blocking the equality check that allowed the layer to update. This caused the layer to never show that it was ready, even when it was. Fix : When we update the external layer through its capabilities, if there was a baseUrl before, we set the baseUrl of the `updated` layer to the original one, ensuring the layer will be updated.
… ensure WMS supporting such a syntax are correctly supported in our viewer.
4ab3c0c to
91f82d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : Whenever we loaded external layers with parameters in the base URL, we sometimes had issues where the base Url of the get Capabilities and the base URL of the layer were not the same, thus blocking the equality check that allowed the layer to update. This caused the layer to never show that it was ready, even when it was.
Fix : When we update the external layer through its capabilities, if there was a baseUrl before, we set the baseUrl of the
updatedlayer to the original one, ensuring the layer will be updated.Test link