PB-1674: Fix tooltip creating too much height with map buttons#1332
Merged
PB-1674: Fix tooltip creating too much height with map buttons#1332
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1674-tooltip-height-issue
|
| Run status |
|
| Run duration | 06m 56s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
251
|
| View all changes introduced in this branch ↗︎ | |
0620229 to
84ba631
Compare
84ba631 to
12c38d1
Compare
sommerfe
approved these changes
May 9, 2025
3b649b6 to
2b2eedb
Compare
The geolocation button has a "linking background" with the compass button (which isn't visible when pointing north). Since modularization, this background is swelling under the button also fixing an issue with the "share link" input, that was not expending as intended since the tooltip modularization. I also took the opportunity to only color the border of the input when a warning is shown, and moved the tooltip with the warning text to the copy button
2b2eedb to
a93d3f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The geolocation button has a "linking background" with the compass button (which isn't visible when pointing north).
Since modularization, this background is swelling under the button
Test link