PB-1636: add parameter to remove UI in embed view#1316
Merged
Conversation
- Issue : We want to remove the UI from the embed view in some cases, so when we are in käze, we can use the sites native UI. - Fix : We add an URL parameter whose role it is to remove these buttons.
Contributor
Author
|
I'll add a test before asking for a review :) |
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 24s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
pakb
approved these changes
Apr 29, 2025
Comment on lines
+186
to
+193
|
|
||
| /** | ||
| * Flag telling if we should hide the UI elements in the embed viewer. Zoom buttons, 3d | ||
| * button and the `view on geoadmin link` | ||
| * | ||
| * @type Boolean | ||
| */ |
Contributor
There was a problem hiding this comment.
Might make sense to add in there that this is specific for GeoPlateformSchweiz, and that we shouldn't disclose this param (as it will soon be obsolete and GPS will replace the use of iframe with the new JS API as soon as it's available)
only for embed mode
d6462f5 to
dc33ea3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link