PB-1493: add a backdrop and an animation to "Zoom with CTRL" message#1330
Merged
PB-1493: add a backdrop and an animation to "Zoom with CTRL" message#1330
Conversation
dcd8b09 to
e9fe9d9
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1493-add-backdrop-and-animation
|
| Run status |
|
| Run duration | 05m 24s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
251
|
| View all changes introduced in this branch ↗︎ | |
e9fe9d9 to
0064e53
Compare
sommerfe
approved these changes
May 8, 2025
Contributor
sommerfe
left a comment
There was a problem hiding this comment.
LGTM
Sometimes when checking the checkbox you can still scroll with the mouse without holding ctrl, but probably not related to this ticket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When embedding the viewer, and activating the "Only CTRL + Wheel to zoom" checkbox, the visual feedback was a bit weak IMO, so I added a black transparent backdrop when showing the message, and centered it so that it doesn't cover the "show on map.geo.admin.ch" link on a small embed
Test link