Skip to content

PB-540 : fixing drawing tooltip missing "edit line" texts#1305

Merged
pakb merged 1 commit intodevelopfrom
fix-PB-540-harmonize-i18n-with-spreadsheet
Apr 18, 2025
Merged

PB-540 : fixing drawing tooltip missing "edit line" texts#1305
pakb merged 1 commit intodevelopfrom
fix-PB-540-harmonize-i18n-with-spreadsheet

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Apr 17, 2025

Updating all i18n translation JSON through the script (some values have been formatted or slightly changed because of that)

Tweaking a bit the DrawingTooltip component so that it now properly shows the "Click to add a point" text when hover over a selected line/measure feature.

Test link

@github-actions github-actions bot added the bug label Apr 17, 2025
Updating all i18n translation JSON through the script (some values have been formatted or slightly changed because of that)

Tweaking a bit the DrawingTooltip component so that it now properly shows the "Click to add a point" text when hover over a selected line/measure feature.
@pakb pakb force-pushed the fix-PB-540-harmonize-i18n-with-spreadsheet branch from 8d66a0e to 391c7bb Compare April 17, 2025 13:56
@cypress
Copy link

cypress bot commented Apr 17, 2025

web-mapviewer    Run #5081

Run Properties:  status check passed Passed #5081  •  git commit 4af6e658c7: Merge pull request #1305 from geoadmin/fix-PB-540-harmonize-i18n-with-spreadshee...
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #5081
Run duration 01m 22s
Commit git commit 4af6e658c7: Merge pull request #1305 from geoadmin/fix-PB-540-harmonize-i18n-with-spreadshee...
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

Copy link
Contributor

@ismailsunni ismailsunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pakb pakb merged commit 4af6e65 into develop Apr 18, 2025
6 checks passed
@pakb pakb deleted the fix-PB-540-harmonize-i18n-with-spreadsheet branch April 18, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants