PB-1202 : Fix overflow issue in 3D feature tooltip view on Chrome#1301
Merged
sami-nouidri-swisstopo merged 2 commits intodevelopfrom Apr 17, 2025
Merged
Conversation
42e3c81 to
7d8adde
Compare
pakb
reviewed
Apr 16, 2025
Contributor
pakb
left a comment
There was a problem hiding this comment.
there's some overflow now in 2D, see here
but not in 3D
packages/mapviewer/src/modules/infobox/components/FeatureList.vue
Outdated
Show resolved
Hide resolved
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 23s |
| Commit |
|
| Committer | Sami Nouidri |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
7d8adde to
cd2dca9
Compare
7cb55d6 to
581fbbd
Compare
pakb
reviewed
Apr 17, 2025
Contributor
pakb
left a comment
There was a problem hiding this comment.
Can you also remove the use of the now deleted fluid prop in OpenLayersHighlightedFeatures.vue?
packages/mapviewer/src/modules/infobox/components/FeatureList.vue
Outdated
Show resolved
Hide resolved
aa5c340 to
aa89bcb
Compare
added 2 commits
April 17, 2025 10:23
Issue : An overflow was causing two scroll bars to appear on Chromium browsers when using the 3D view. Fix : removed the fluid css condition and set a consistent max-height of 100%
aa89bcb to
608ef3e
Compare
pakb
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : An overflow was causing two scroll bars to appear on Chromium browsers when using the 3D view.
Fix : removed the fluid css condition, and added logic to switch max height depending on aspect ratio of viewport.
Test link