Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1672-menu-collapse
|
| Run status |
|
| Run duration | 07m 00s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
251
|
| View all changes introduced in this branch ↗︎ | |
b8f69b7 to
78168df
Compare
Looks like some recent changes (tailwind?) have broken the now old Vue2 component that was handling the collapse animation for the menu. There’s now alternative made in Vue3, we should migrate
a99ebe7 to
4730699
Compare
The current setup wasn't working, so I added a new "mode" to Vite to differentiate when we run Cypress or when we develop. This is due to some test failing if the devtools are present (menuTray.cy.js is one example)
4730699 to
e0cdbdc
Compare
sommerfe
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like some recent changes (tailwind?) have broken the now old Vue2 component that was handling the collapse animation for the menu.
There’s now alternative made in Vue3 (Vue Collapsed) we should migrate
Test link