Conversation
PB-1208 : Have layer legend behind the menu on mobile
…info-from-search PB-1209: Fix no feature tooltip when select feature from search.
PB-577: Sanitize kml content
Don't render the invisible layer catalogue items. Only render them when the nested navigation is un-collapsed. This produces quite a performance gain, as many sub-sequent components don't need rendering. This includes <TextTruncate>, where each of them creates a ResizeObserver on the DOM. Without this change we have ~1100 resize observers, with the change there are only ~250. I will investigate those ~250 maybe in another attempt, some of them might be resolved when switching to the new tooltip.
Don't render invisible layer catalogue items
Bump npm version to 11 in package.json
Adding a workspace configuration with a catalog to be used from all our packages. This will require to run `pnpm install` on the top level and it will install all required packages in our modularized packages. The catalog in the workspace configuration helps having the same version across all our sub-packages.
The transparency slider doesn't work correctly when there are more than one layer with the same ID. The opacity will be changed on the first layer that is found in the list instead of the one that it's applied on
This reverts commit 97a44a5.
The civil icon descriptions weren't appearing anymore, maybe due to a refactoring mistake
Improve the geoadmin tooltip so that it can be specified to use the padding even if the content slot is used. This removes the need for adding the same padding in several places
This makes us ready for a future switch away from bootstrap
This reverts commit 8dc6bb9.
Due to the nature of GeoadminTooltip an element was wrapped with that new component. This lead to the situation where cypress couldn't select the correct element. Now instead of working around this with a prop to the component lets change the selector in cypress and add the attribute programmatically just before creating the ol/Overlay
This reverts commit 3ba9c96.
[sort-package-json](https://www.npmjs.com/package/sort-package-json)
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 01m 38s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
1
|
|
|
0
|
|
|
48
|
| View all changes introduced in this branch ↗︎ | |
Previously, the formatting target in package.json only targeted the code underneath packages/. If we want to include the package.json in the root level, maybe we should allow formatting the entire codebase. This has an effect of the ADR as well as the README's, but maybe that's not even a a bad thing
Include packages.json formatting in Prettier
users on touch devices could trigger a delete by double tapping on the last point they were drawing, which wasn't ideal. As I've run out of ideas on how to fix this on mobile, I've simply removed the possibility to delete a point on mobile as we lack "gestures" to achieve it.
we need to have right click hooked up to the "delete point under cursor" when not editing/extending a feature
schtibe
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link