Skip to content

New Release v1.53.0 - #minor#1259

Merged
pakb merged 159 commits intomasterfrom
develop
Mar 17, 2025
Merged

New Release v1.53.0 - #minor#1259
pakb merged 159 commits intomasterfrom
develop

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Mar 12, 2025

Sami Nouidri and others added 30 commits February 17, 2025 13:54
PB-1208 : Have layer legend behind the menu on mobile
Don't render the invisible layer catalogue items. Only render them when
the nested navigation is un-collapsed.
This produces quite a performance gain, as many sub-sequent components
don't need rendering. This includes <TextTruncate>, where each of them
creates a ResizeObserver on the DOM. Without this change we have ~1100
resize observers, with the change there are only ~250.

I will investigate those ~250 maybe in another attempt, some of them
might be resolved when switching to the new tooltip.
Don't render invisible layer catalogue items
Bump npm version to 11 in package.json
Adding a workspace configuration with a catalog to be used from all our
packages. This will require to run `pnpm install` on the top level and
it will install all required packages in our modularized packages.

The catalog in the workspace configuration helps having the same version
across all our sub-packages.
schtibe and others added 19 commits March 17, 2025 10:04
The transparency slider doesn't work correctly when there are more than
one layer with the same ID. The opacity will be changed on the first
layer that is found in the list instead of the one that it's applied on
The civil icon descriptions weren't appearing anymore, maybe due to a
refactoring mistake
Improve the geoadmin tooltip so that it can be specified to use the
padding even if the content slot is used. This removes the need for
adding the same padding in several places
This makes us ready for a future switch away from bootstrap
Due to the nature of GeoadminTooltip an element was wrapped with that
new component. This lead to the situation where cypress couldn't select
the correct element.
Now instead of working around this with a prop to the component lets
change the selector in cypress and add the attribute programmatically
just before creating the ol/Overlay
@cypress
Copy link

cypress bot commented Mar 17, 2025

web-mapviewer    Run #4810

Run Properties:  status check passed Passed #4810  •  git commit 226713d611: Merge pull request #1259 from geoadmin/develop
Project web-mapviewer
Branch Review master
Run status status check passed Passed #4810
Run duration 01m 38s
Commit git commit 226713d611: Merge pull request #1259 from geoadmin/develop
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

schtibe and others added 6 commits March 17, 2025 13:50
Previously, the formatting target in package.json only targeted the code
underneath packages/.

If we want to include the package.json in the root level, maybe we
should allow formatting the entire codebase. This has an effect of the
ADR as well as the README's, but maybe that's not even a a bad thing
Include packages.json formatting in Prettier
users on touch devices could trigger a delete by double tapping on the last point they were drawing, which wasn't ideal.

As I've run out of ideas on how to fix this on mobile, I've simply removed the possibility to delete a point on mobile as we lack "gestures" to achieve it.
we need to have right click hooked up to the "delete point under cursor" when not editing/extending a feature
@pakb pakb requested a review from schtibe March 17, 2025 14:50
…t-click

PB-1004 : only use right click to trigger "delete point" action
@pakb pakb merged commit 226713d into master Mar 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants